MC-22829: Revert ticket MAGETWO-96975 which introduce BIC on 2.3.4

Author: svitja

dev/tests/static/framework/Magento/CodeMessDetector/Rule/Design/SerializationAware.php

@@ -10,6 +10,29 @@
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
          xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
+    <rule name="FinalImplementation"
+          class="Magento\CodeMessDetector\Rule\Design\FinalImplementation"
+          message= "The {0} {1} declared as final.">
+        <description>
+            <![CDATA[
+Final keyword is prohibited in Magento as this decreases extensibility and customizability.
+Final classes and method are not compatible with plugins and proxies.
+            ]]>
+        </description>
+        <priority>1</priority>
+        <properties />
+        <example>
+            <![CDATA[
+final class Foo
+{
+    public function bar() {}
+}
+class Baz {
+    final public function bad() {}
+}
+            ]]>
+        </example>
+    </rule>
     <rule name="AllPurposeAction"
           class="Magento\CodeMessDetector\Rule\Design\AllPurposeAction"
           message= "The class {0} does not restrict processed HTTP methods by implementing a Http*Method name*ActionInterface">
@@ -60,31 +83,6 @@ class OrderProcessor
         $currentOrder = $this->session->get('current_order');
         ...
     }
-}
-            ]]>
-        </example>
-    </rule>
-    <rule name="SerializationAware"
-          class="Magento\CodeMessDetector\Rule\Design\SerializationAware"
-          message="{1} has {0} method and is PHP serialization aware - PHP serialization must be avoided.">
-        <description>
-            <![CDATA[
-Using PHP serialization must be avoided in Magento for security reasons and for prevention of unexpected behaviour.
-            ]]>
-        </description>
-        <priority>2</priority>
-        <properties />
-        <example>
-            <![CDATA[
-class MyModel extends AbstractModel
-{
-
-    .......
-
-    public function __sleep()
-    {
-        .....
-    }
 }
             ]]>
         </example>

dev/tests/static/framework/Magento/CodeMessDetector/resources/rulesets/design.xml

@@ -29,6 +29,9 @@
     <rule ref="rulesets/unusedcode.xml" />
 
     <!-- Code design rules -->
+    <rule ref="rulesets/design.xml/ExitExpression" />
+    <rule ref="rulesets/design.xml/EvalExpression" />
+    <rule ref="rulesets/design.xml/GotoStatement" />
     <rule ref="rulesets/design.xml/NumberOfChildren" />
     <rule ref="rulesets/design.xml/DepthOfInheritance">
         <properties>
@@ -43,8 +46,8 @@
     <rule ref="rulesets/naming.xml/BooleanGetMethodName" />
 
     <!-- Magento Specific Rules -->
+    <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/FinalImplementation" />
     <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/AllPurposeAction" />
     <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/CookieAndSessionMisuse" />
-    <rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/SerializationAware" />
 
 </ruleset>