MAGETWO-66402: Backward Incompatible Change

- moving getAllIds into \Magento\Framework\View\Element\UiComponentInterface as it already contains methods not related to interface and we will probably deprecate this interface at some point and refactor UiComponent

Author: cpartica

app/code/Magento/Ui/Component/AbstractComponent.php

@@ -301,29 +301,4 @@ protected function initObservers(array & $data = [])
             }
         }
     }
-
-
-    /**
-     * Retrieve all ids from Search Result
-     *
-     * @return int[]
-     */
-    public function getAllIds()
-    {
-        $searchResult = $this->getContext()->getDataProvider()->getSearchResult();
-        $idsArray = [];
-
-        if ($searchResult instanceof \Magento\Eav\Model\Entity\Collection\AbstractCollection
-            || $searchResult instanceof \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection
-        ) {
-            // Query optimization as SearchResultInterface doesn't have optimization for retrieving just ids
-            $idsArray = $searchResult->getAllIds();
-        } else {
-            foreach ($searchResult->getItems() as $item) {
-                /** @var $item \Magento\Framework\Api\Search\DocumentInterface */
-                $idsArray[] = $item->getId();
-            }
-        }
-        return $idsArray;
-    }
 }

app/code/Magento/Ui/Component/MassAction/Filter.php

@@ -217,7 +217,19 @@ private function getDataProvider()
      */
     private function getFilterIds()
     {
+        $idsArray = [];
         $this->applySelectionOnTargetProvider();
-        return $this->getComponent()->getAllIds();
+        if ($this->getDataProvider() instanceof \Magento\Ui\DataProvider\AbstractDataProvider) {
+            // Use collection's getItems for optimization purposes
+            return $this->getDataProvider()->getAllIds();
+        } else {
+            $searchResult = $this->getDataProvider()->getSearchResult();
+            // Use compatible search api getItems when searchResult is not a collection.
+            foreach ($searchResult->getItems() as $item) {
+                /** @var $item \Magento\Framework\Api\Search\DocumentInterface */
+                $idsArray[] = $item->getId();
+            }
+        }
+        return  $idsArray;
     }
 }

app/code/Magento/Ui/DataProvider/AbstractDataProvider.php

@@ -172,7 +172,7 @@ public function getSearchCriteria()
     /**
      * Returns SearchResult
      *
-     * @return null
+     * @return AbstractCollection
      */
     public function getSearchResult()
     {
@@ -279,4 +279,14 @@ public function setConfigData($config)
     {
         $this->data['config'] = $config;
     }
+
+    /**
+     * Retrieve all ids from Search Result
+     *
+     * @return int[]
+     */
+    public function getAllIds()
+    {
+        return $this->getSearchResult()->getAllIds();
+    }
 }

lib/internal/Magento/Framework/View/Element/UiComponentInterface.php

@@ -125,11 +125,4 @@ public function prepareDataSource(array $dataSource);
      * @return array
      */
     public function getDataSourceData();
-
-    /**
-     * Retrieve all ids from Search Result
-     *
-     * @return int[]
-     */
-    public function getAllIds();
 }