MAGETWO-66402: Backward Incompatible Change

- moving getAllIds into \Magento\Framework\View\Element\UiComponentInterface as it already contains methods not related to interface and we will probably deprecate this interface at some point and refactor UiComponent

Author: cpartica

app/code/Magento/Ui/Component/AbstractComponent.php

@@ -301,4 +301,29 @@ protected function initObservers(array & $data = [])
             }
         }
     }
+
+
+    /**
+     * Retrieve all ids from Search Result
+     *
+     * @return int[]
+     */
+    public function getAllIds()
+    {
+        $searchResult = $this->getContext()->getDataProvider()->getSearchResult();
+        $idsArray = [];
+
+        if ($searchResult instanceof \Magento\Eav\Model\Entity\Collection\AbstractCollection
+            || $searchResult instanceof \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection
+        ) {
+            // Query optimization as SearchResultInterface doesn't have optimization for retrieving just ids
+            $idsArray = $searchResult->getAllIds();
+        } else {
+            foreach ($searchResult->getItems() as $item) {
+                /** @var $item \Magento\Framework\Api\Search\DocumentInterface */
+                $idsArray[] = $item->getId();
+            }
+        }
+        return $idsArray;
+    }
 }

app/code/Magento/Ui/Component/MassAction/Filter.php

@@ -218,9 +218,6 @@ private function getDataProvider()
     private function getFilterIds()
     {
         $this->applySelectionOnTargetProvider();
-        if ($this->getDataProvider()->getSearchResult()) {
-            return $this->getDataProvider()->getSearchResult()->getAllIds();
-        }
-        return [];
+        return $this->getComponent()->getAllIds();
     }
 }

lib/internal/Magento/Framework/Api/Search/SearchResult.php

@@ -85,18 +85,4 @@ public function setTotalCount($totalCount)
     {
         return $this->setData(self::TOTAL_COUNT, $totalCount);
     }
-
-    /**
-     * Retrieve ids of all items
-     *
-     * @return array
-     */
-    public function getAllIds()
-    {
-        $ids = [];
-        foreach ($this->getItems() as $item) {
-            $ids[] = $item->getId();
-        }
-        return $ids;
-    }
 }

lib/internal/Magento/Framework/Api/Search/SearchResultInterface.php

@@ -53,11 +53,4 @@ public function setAggregations($aggregations);
      * @return \Magento\Framework\Api\Search\SearchCriteriaInterface
      */
     public function getSearchCriteria();
-
-    /**
-     * Retrieve all ids from list
-     *
-     * @return int[]
-     */
-    public function getAllIds();
 }

lib/internal/Magento/Framework/Api/Test/Unit/Search/SearchResultTest.php

@@ -54,14 +54,6 @@ protected function setUp()
         );
     }
 
-    /**
-     * Test getAllIds
-     */
-    public function testGetAllIds()
-    {
-        $this->assertEquals([1, 2], $this->search->getAllIds());
-    }
-
     /**
      * Test getItems
      */

lib/internal/Magento/Framework/View/Element/UiComponentInterface.php

@@ -125,4 +125,11 @@ public function prepareDataSource(array $dataSource);
      * @return array
      */
     public function getDataSourceData();
+
+    /**
+     * Retrieve all ids from Search Result
+     *
+     * @return int[]
+     */
+    public function getAllIds();
 }