MAGETWO-33579: Refactor Tax module to use factories instead of builders

    - Changed setTaxIncluded to setIsTaxIncluded

Author: Yu Tang

app/code/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollector.php

@@ -204,15 +204,16 @@ public function mapItem(
             $sequence = 'sequence-' . $this->getNextIncrement();
             $item->setTaxCalculationItemId($sequence);
         }
-        $itemDataObject = $itemDataObjectFactory->create()
-            ->setCode($item->getTaxCalculationItemId())
+        /** @var \Magento\Tax\Api\Data\QuoteDetailsItemInterface $itemDataObject */
+        $itemDataObject = $itemDataObjectFactory->create();
+        $itemDataObject->setCode($item->getTaxCalculationItemId())
             ->setQuantity($item->getQty())
             ->setTaxClassKey(
                 $this->taxClassKeyDataObjectFactory->create()
                     ->setType(TaxClassKeyInterface::TYPE_ID)
                     ->setValue($item->getProduct()->getTaxClassId())
             )
-            ->setTaxIncluded($priceIncludesTax)
+            ->setIsTaxIncluded($priceIncludesTax)
             ->setType(self::ITEM_TYPE_PRODUCT);
 
         if ($useBaseCurrency) {
@@ -264,6 +265,7 @@ public function mapItemExtraTaxables(
             } else {
                 $unitPrice = $extraTaxable[self::KEY_ASSOCIATED_TAXABLE_UNIT_PRICE];
             }
+            /** @var \Magento\Tax\Api\Data\QuoteDetailsItemInterface $itemDataObject */
             $itemDataObject = $itemDataObjectFactory->create();
             $itemDataObject->setCode($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_CODE])
                 ->setType($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_TYPE])
@@ -274,7 +276,7 @@ public function mapItemExtraTaxables(
                         ->setValue($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_TAX_CLASS_ID])
                 )
                 ->setUnitPrice($unitPrice)
-                ->setTaxIncluded($extraTaxableIncludesTax)
+                ->setIsTaxIncluded($extraTaxableIncludesTax)
                 ->setAssociatedItemCode($item->getTaxCalculationItemId());
             $itemDataObjects[] = $itemDataObject;
         }
@@ -372,6 +374,7 @@ public function getShippingDataObject(QuoteAddress $address, $useBaseCurrency)
             $address->setBaseShippingTaxCalculationAmount($address->getBaseShippingAmount());
         }
         if ($address->getShippingTaxCalculationAmount() !== null) {
+            /** @var \Magento\Tax\Api\Data\QuoteDetailsItemInterface $itemDataObject */
             $itemDataObject = $this->quoteDetailsItemDataObjectFactory->create()
                 ->setType(self::ITEM_TYPE_SHIPPING)
                 ->setCode(self::ITEM_CODE_SHIPPING)
@@ -393,7 +396,9 @@ public function getShippingDataObject(QuoteAddress $address, $useBaseCurrency)
                     ->setType(TaxClassKeyInterface::TYPE_ID)
                     ->setValue($this->_config->getShippingTaxClass($address->getQuote()->getStore()))
             );
-            $itemDataObject->setTaxIncluded($this->_config->shippingPriceIncludesTax($address->getQuote()->getStore()));
+            $itemDataObject->setIsTaxIncluded(
+                $this->_config->shippingPriceIncludesTax($address->getQuote()->getStore())
+            );
             return $itemDataObject;
         }
 

app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php

@@ -218,7 +218,7 @@ public function mapQuoteExtraTaxables(
                         ->setValue($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_TAX_CLASS_ID])
                 )
                 ->setUnitPrice($unitPrice)
-                ->setTaxIncluded($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_PRICE_INCLUDES_TAX])
+                ->setIsTaxIncluded($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_PRICE_INCLUDES_TAX])
                 ->setAssociatedItemCode($extraTaxable[self::KEY_ASSOCIATED_TAXABLE_ASSOCIATION_ITEM_CODE]);
         }