MAGETWO-33488: Add setters to data object interfaces in Tax module

    - Replaced some string literals with constant

Author: Yu Tang

app/code/Magento/Tax/Api/Data/TaxRateInterface.php

@@ -17,6 +17,7 @@ interface TaxRateInterface extends \Magento\Framework\Api\ExtensibleDataInterfac
     const KEY_REGION_ID = 'tax_region_id';
     const KEY_REGION_NAME = 'region_name';
     const KEY_POSTCODE = 'tax_postcode';
+    const KEY_ZIP_IS_RANGE = 'zip_is_range';
     const KEY_ZIP_RANGE_FROM = 'zip_from';
     const KEY_ZIP_RANGE_TO = 'zip_to';
     const KEY_PERCENTAGE_RATE = 'rate';

app/code/Magento/Tax/Model/Calculation/Rate.php

@@ -372,7 +372,7 @@ public function getCode()
      */
     public function getZipIsRange()
     {
-        return $this->getData('zip_is_range');
+        return $this->getData(self::KEY_ZIP_IS_RANGE);
     }
     /**
      * Set country id
@@ -426,7 +426,7 @@ public function setTaxPostcode($taxPostCode)
      */
     public function setZipIsRange($zipIsRange)
     {
-        return $this->setData('zip_is_range', $zipIsRange);
+        return $this->setData(self::KEY_ZIP_IS_RANGE, $zipIsRange);
     }
 
     /**

app/code/Magento/Tax/Model/Calculation/Rule.php

@@ -5,7 +5,6 @@
  */
 namespace Magento\Tax\Model\Calculation;
 
-use int;
 use Magento\Framework\Api\AttributeValueFactory;
 use Magento\Framework\Api\MetadataServiceInterface;
 use Magento\Tax\Api\Data\TaxRuleInterface;

app/code/Magento/Tax/Model/ClassModel.php

@@ -123,23 +123,23 @@ public function beforeDelete()
      */
     public function getClassId()
     {
-        return $this->getData('class_id');
+        return $this->getData(self::KEY_ID);
     }
 
     /**
      * {@inheritdoc}
      */
     public function getClassName()
     {
-        return $this->getData('class_name');
+        return $this->getData(self::KEY_NAME);
     }
 
     /**
      * {@inheritdoc}
      */
     public function getClassType()
     {
-        return $this->getData('class_type');
+        return $this->getData(self::KEY_TYPE);
     }
     /**
      * Set tax class ID.
@@ -149,7 +149,7 @@ public function getClassType()
      */
     public function setClassId($classId)
     {
-        return $this->setData('class_id', $classId);
+        return $this->setData(self::KEY_ID, $classId);
     }
 
     /**
@@ -160,7 +160,7 @@ public function setClassId($classId)
      */
     public function setClassName($className)
     {
-        return $this->setData('class_name', $className);
+        return $this->setData(self::KEY_NAME, $className);
     }
 
     /**
@@ -171,7 +171,7 @@ public function setClassName($className)
      */
     public function setClassType($classType)
     {
-        return $this->setData('class_type', $classType);
+        return $this->setData(self::KEY_TYPE, $classType);
     }
     //@codeCoverageIgnoreEnd
 }