Skip to content

Commit bfd3175

Browse files
MC-37313: [Create UPS shipping label] Error message appears "Failed to send items" if Signature Confirmation is set to Not Required
1 parent e90df20 commit bfd3175

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

app/code/Magento/Ups/Model/Carrier.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,6 +1118,7 @@ protected function _getXmlTracking($trackings)
11181118

11191119
/** @var HttpResponseDeferredInterface[] $trackingResponses */
11201120
$trackingResponses = [];
1121+
$tracking = '';
11211122
foreach ($trackings as $tracking) {
11221123
/**
11231124
* RequestOption==>'1' to request all activities
@@ -1362,6 +1363,7 @@ public function getAllowedMethods()
13621363
protected function _formShipmentRequest(DataObject $request)
13631364
{
13641365
$packages = $request->getPackages();
1366+
$shipmentItems = [];
13651367
foreach ($packages as $package) {
13661368
$shipmentItems[] = $package['items'];
13671369
}
@@ -1624,6 +1626,7 @@ protected function _sendShipmentAcceptRequest(Element $shipmentConfirmResponse)
16241626
$xmlResponse = '';
16251627
}
16261628

1629+
$response = '';
16271630
try {
16281631
$response = $this->_xmlElFactory->create(['data' => $xmlResponse]);
16291632
} catch (Throwable $e) {
@@ -1800,6 +1803,7 @@ protected function _doShipmentRequest(DataObject $request)
18001803
$this->setXMLAccessRequest();
18011804
$xmlRequest = $this->_xmlAccessRequest . $rawXmlRequest;
18021805
$xmlResponse = $this->_getCachedQuotes($xmlRequest);
1806+
$debugData = [];
18031807

18041808
if ($xmlResponse === null) {
18051809
$debugData['request'] = $this->filterDebugData($this->_xmlAccessRequest) . $rawXmlRequest;

dev/tests/integration/testsuite/Magento/Ups/Model/CarrierTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,8 @@ public function testRequestToShipment(): void
252252
'weight' => '0.55',
253253
'customs_value' => '20.00',
254254
'container' => 'Large Express Box',
255+
'delivery_confirmation_level' => 1,
256+
'delivery_confirmation' => 0,
255257
],
256258
'items' => [
257259
'item2' => [
@@ -262,6 +264,7 @@ public function testRequestToShipment(): void
262264
]
263265
]
264266
);
267+
$request->setRecipientAddressCountryCode('UK');
265268

266269
$result = $this->carrier->requestToShipment($request);
267270

dev/tests/integration/testsuite/Magento/Ups/_files/ShipmentConfirmRequest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<AddressLine1 />
2828
<AddressLine2 />
2929
<City />
30-
<CountryCode />
30+
<CountryCode>UK</CountryCode>
3131
<PostalCode />
3232
<ResidentialAddress />
3333
</Address>

0 commit comments

Comments
 (0)