MC-37313: [Create UPS shipping label] Error message appears "Failed to send items" if Signature Confirmation is set to Not Required

yelahin-serhiy · yelahin-serhiy · commit e90df20ec0ed · 2020-09-04T12:06:29.000+03:00
diff --git a/app/code/Magento/Ups/Model/Carrier.php b/app/code/Magento/Ups/Model/Carrier.php
@@ -1538,7 +1538,7 @@ protected function _formShipmentRequest(DataObject $request)
             }
         }
 
-        if (isset($deliveryConfirmation) && $deliveryConfirmationLevel === self::DELIVERY_CONFIRMATION_SHIPMENT) {
+        if (!empty($deliveryConfirmation) && $deliveryConfirmationLevel === self::DELIVERY_CONFIRMATION_SHIPMENT) {
             $serviceOptionsNode = $shipmentPart->addChild('ShipmentServiceOptions');
             $serviceOptionsNode->addChild(
                 'DeliveryConfirmation'

Original file line number	Diff line number	Diff line change
`@@ -1538,7 +1538,7 @@ protected function _formShipmentRequest(DataObject $request)`
`1538`	`1538`	`}`
`1539`	`1539`	`}`
`1540`	`1540`
`1541`		`- if (isset($deliveryConfirmation) && $deliveryConfirmationLevel === self::DELIVERY_CONFIRMATION_SHIPMENT) {`
	`1541`	`+ if (!empty($deliveryConfirmation) && $deliveryConfirmationLevel === self::DELIVERY_CONFIRMATION_SHIPMENT) {`
`1542`	`1542`	`$serviceOptionsNode = $shipmentPart->addChild('ShipmentServiceOptions');`
`1543`	`1543`	`$serviceOptionsNode->addChild(`
`1544`	`1544`	`'DeliveryConfirmation'`