Skip to content

Commit a68c379

Browse files
Manoranjan.PrakashManoranjan.Prakash
authored andcommitted
updated the script as per reviewed comments
1 parent 65dbff0 commit a68c379

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

app/code/Magento/Catalog/Test/Mftf/Section/AdminProductGridSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
<element name="allowGiftsWrapCheckbox" type="checkbox" selector="//input[@type='checkbox' and @name='product[use_config_gift_wrapping_available]']" />
4545
<element name="allowGiftsWrapToggle" type="button" selector="//input[@type='checkbox' and @name='product[use_config_gift_wrapping_available]' and @value='{{var1}}']/../../../..//label[@class='admin__actions-switch-label']" parameterized="true"/>
4646
<element name="priceForGiftsWrapping" type="input" selector="//input[@name='product[gift_wrapping_price]']"/>
47-
<element name="productImgInGrid" type="block" selector="img.admin__control-thumbnail[src*='/large']" />
4847
</section>
4948
</sections>
5049

app/code/Magento/Catalog/Test/Mftf/Section/StorefrontCategoryMainSection.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,5 @@
4545
<element name="productAttributeOptionValue" type="button" selector="//div[@id='narrow-by-list']//a[contains(text(), '{{var1}}')]" parameterized="true"/>
4646
<element name="outOfStockProductCategoryPage" type="text" selector="//div[@class='stock unavailable']//span[text()='Out of stock']"/>
4747
<element name="ListedProductAttributes" type="block" selector="//div[@aria-label='{{vs_attribute}}']//div[@aria-label='{{attribute_name}}']" parameterized="true"/>
48-
<element name="uploadedImageLarge" type="text" selector=".products-grid img[src*='/large']"/>
49-
<element name="uploadedImageSmallLarge" type="text" selector=".products-grid img[src*='placeholder/small_image.jpg']"/>
5048
</section>
5149
</sections>

app/code/Magento/Catalog/Test/Mftf/Test/AdminSimpleProductImagesTest/AdminSimpleProductImagesTest.xml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,7 @@
119119

120120
<!-- Go to the category page and see a placeholder image for the second product -->
121121
<amOnPage url="$$category.custom_attributes[url_key]$$.html" stepKey="goToCategoryPage"/>
122-
<waitForElementVisible selector="{{StorefrontCategoryMainSection.uploadedImageSmallLarge}}" stepKey="waitForPlaceholder"/>
123-
<seeElement selector="{{StorefrontCategoryMainSection.uploadedImageSmallLarge}}" stepKey="seePlaceHolder"/>
122+
<seeElement selector="{{StorefrontCategoryProductSection.ProductImageBySrc('placeholder/small_image.jpg')}}" stepKey="seePlaceHolder"/>
124123

125124
<!-- Go to the second product edit page -->
126125
<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="goToProductIndex2"/>
@@ -151,15 +150,15 @@
151150
<actionGroup ref="FilterProductGridBySkuActionGroup" stepKey="filterProductGridBySku3">
152151
<argument name="product" value="$$secondProduct$$"/>
153152
</actionGroup>
154-
<seeElement selector="{{AdminProductGridSection.productImgInGrid}}" stepKey="seeImgInGrid"/>
153+
<waitForElementVisible selector="{{AdminProductGridSection.productThumbnailBySrc('/large')}}" stepKey="seeImgInGrid"/>
155154

156155
<!-- Go to the category page and see the uploaded image -->
157156
<amOnPage url="$$category.custom_attributes[url_key]$$.html" stepKey="goToStorefrontCategoryPage"/>
158-
<waitForElementVisible selector="{{StorefrontCategoryMainSection.uploadedImageLarge}}" stepKey="seeUploadedImg"/>
157+
<waitForElementVisible selector="{{StorefrontCategoryProductSection.ProductImageBySrc('/large')}}" stepKey="goToCategoryPage2"/>
159158

160159
<!-- Go to the product page and see the uploaded image -->
161-
<amOnPage url="$$secondProduct.custom_attributes[url_key]$$.html" stepKey="goToStorefrontProductPage"/>
160+
<amOnPage url="$$secondProduct.custom_attributes[url_key]$$.html" stepKey="goToStorefront2"/>
162161
<waitForPageLoad stepKey="waitForStorefrontProductPageToLoad"/>
163-
<seeElementInDOM selector="{{StorefrontProductMediaSection.imageFile('large')}}" stepKey="seeLarge2"/>
162+
<waitForElementVisible selector="{{StorefrontProductMediaSection.imageFile('large')}}" stepKey="seeLarge2"/>
164163
</test>
165164
</tests>

0 commit comments

Comments
 (0)