Skip to content

Commit 65dbff0

Browse files
Manoranjan.PrakashManoranjan.Prakash
authored andcommitted
unwanted waits removed and stepkeys renamed back as per advise from David
1 parent 06615ad commit 65dbff0

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

app/code/Magento/Catalog/Test/Mftf/Section/AdminProductGridSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
<element name="allowGiftsWrapCheckbox" type="checkbox" selector="//input[@type='checkbox' and @name='product[use_config_gift_wrapping_available]']" />
4545
<element name="allowGiftsWrapToggle" type="button" selector="//input[@type='checkbox' and @name='product[use_config_gift_wrapping_available]' and @value='{{var1}}']/../../../..//label[@class='admin__actions-switch-label']" parameterized="true"/>
4646
<element name="priceForGiftsWrapping" type="input" selector="//input[@name='product[gift_wrapping_price]']"/>
47+
<element name="productImgInGrid" type="block" selector="img.admin__control-thumbnail[src*='/large']" />
4748
</section>
4849
</sections>
4950

app/code/Magento/Catalog/Test/Mftf/Test/AdminSimpleProductImagesTest/AdminSimpleProductImagesTest.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,17 +151,15 @@
151151
<actionGroup ref="FilterProductGridBySkuActionGroup" stepKey="filterProductGridBySku3">
152152
<argument name="product" value="$$secondProduct$$"/>
153153
</actionGroup>
154-
<seeElement selector="img.admin__control-thumbnail[src*='/large']" stepKey="seeImgInGrid"/>
154+
<seeElement selector="{{AdminProductGridSection.productImgInGrid}}" stepKey="seeImgInGrid"/>
155155

156156
<!-- Go to the category page and see the uploaded image -->
157157
<amOnPage url="$$category.custom_attributes[url_key]$$.html" stepKey="goToStorefrontCategoryPage"/>
158-
<waitForElementVisible selector="{{StorefrontCategoryMainSection.uploadedImageLarge}}" stepKey="waitForUploadedImgOnStorefrontCategoryPage"/>
159-
<seeElement selector="{{StorefrontCategoryMainSection.uploadedImageLarge}}" stepKey="seeUploadedImgOnStorefrontCategoryPage"/>
158+
<waitForElementVisible selector="{{StorefrontCategoryMainSection.uploadedImageLarge}}" stepKey="seeUploadedImg"/>
160159

161160
<!-- Go to the product page and see the uploaded image -->
162161
<amOnPage url="$$secondProduct.custom_attributes[url_key]$$.html" stepKey="goToStorefrontProductPage"/>
163162
<waitForPageLoad stepKey="waitForStorefrontProductPageToLoad"/>
164-
<waitForElementVisible selector="{{StorefrontProductMediaSection.imageFile('large')}}" stepKey="waitForLarge2ImageOnStorefrontProductPage"/>
165-
<seeElementInDOM selector="{{StorefrontProductMediaSection.imageFile('large')}}" stepKey="seeLarge2ImageOnStorefrontProductPage"/>
163+
<seeElementInDOM selector="{{StorefrontProductMediaSection.imageFile('large')}}" stepKey="seeLarge2"/>
166164
</test>
167165
</tests>

0 commit comments

Comments
 (0)