Skip to content

Commit 78c2352

Browse files
author
olysenko
committed
MAGETWO-63716: Add target to admin menu element
1 parent 33498a2 commit 78c2352

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

app/code/Magento/Backend/Block/AnchorRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ public function renderAnchor(Item $activeItem, Item $menuItem, $level)
5252
} else {
5353
$target = $menuItem->getTarget() ? ('target=' . $menuItem->getTarget()) : '';
5454
$output = '<a href="' . $menuItem->getUrl() . '" ' . $target . ' ' . $this->_renderItemAnchorTitle(
55-
$menuItem
56-
) . $this->_renderItemOnclickFunction(
55+
$menuItem
56+
) . $this->_renderItemOnclickFunction(
5757
$menuItem
5858
) . ' class="' . ($this->menuItemChecker->isItemActive($activeItem, $menuItem, $level) ? '_active' : '')
5959
. '">' . '<span>' . $this->escaper->escapeHtml(__($menuItem->getTitle()))

app/code/Magento/Backend/Block/MenuItemChecker.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ public function isItemActive(
4141
* @return bool
4242
*/
4343
private function isActiveItemEqualOrChild($activeItem, $item)
44-
{
44+
{
4545
return ($activeItem->getId() == $item->getId())
4646
|| ($item->getChildren()->get($activeItem->getId()) !== null);
47-
}
47+
}
4848
}

app/code/Magento/Backend/Test/Unit/Block/AnchorRendererTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ public function testRenderAnchorLevelIsNotOne($hasTarget)
120120

121121
$this->assertEquals(
122122
$expected,
123-
$this->anchorRenderer->renderAnchor($this->activeMenuItemMock, $this->menuItemMock, $level));
123+
$this->anchorRenderer->renderAnchor($this->activeMenuItemMock, $this->menuItemMock, $level)
124+
);
124125
}
125126

126127
public function targetDataProvider()

app/code/Magento/Backend/Test/Unit/Block/MenuItemCheckerTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,16 @@ public function testIsItemActive($activeItemId, $itemId, $isItem, $expected)
6161
->method('get')
6262
->with($activeItemId)
6363
->willReturn($isItem ? $this->activeMenuItemMock : null);
64-
$this->assertEquals($expected,
64+
$this->assertEquals(
65+
$expected,
6566
$this->menuItemChecker->isItemActive($this->activeMenuItemMock, $this->menuItemMock, 0)
66-
6767
);
6868
}
6969

7070
public function testIsItemActiveLevelNotZero()
7171
{
7272
$this->assertFalse(
7373
$this->menuItemChecker->isItemActive($this->activeMenuItemMock, $this->menuItemMock, 1)
74-
7574
);
7675
}
7776

0 commit comments

Comments
 (0)