Skip to content

Commit 33498a2

Browse files
author
olysenko
committed
MAGETWO-63716: Add target to admin menu element
1 parent 787b720 commit 33498a2

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

app/code/Magento/Backend/Block/AnchorRenderer.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public function __construct(
3737

3838
/**
3939
* Render menu item anchor
40+
*
4041
* @param Item $activeItem
4142
* @param Item $menuItem
4243
* @param int $level

app/code/Magento/Backend/Model/Menu/Item.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ class Item
152152
*
153153
* @var string|null
154154
*/
155-
protected $target;
155+
private $target;
156156

157157
/**
158158
* @param Item\Validator $validator
@@ -211,7 +211,7 @@ public function getId()
211211
/**
212212
* Retrieve item target
213213
*
214-
* @return string
214+
* @return string|null
215215
*/
216216
public function getTarget()
217217
{

app/code/Magento/Backend/Test/Unit/Block/MenuTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ class MenuTest extends \PHPUnit_Framework_TestCase
3838
/**
3939
* @var UrlInterface|\PHPUnit_Framework_MockObject_MockObject
4040
*/
41-
protected $urlMock;
41+
private $urlMock;
4242

4343
/**
4444
* @var IteratorFactory|\PHPUnit_Framework_MockObject_MockObject
4545
*/
46-
protected $iteratorFactoryMock;
46+
private $iteratorFactoryMock;
4747

4848
/**
4949
* @var Session|\PHPUnit_Framework_MockObject_MockObject
@@ -71,7 +71,7 @@ class MenuTest extends \PHPUnit_Framework_TestCase
7171
private $menuItemCheckerMock;
7272

7373
/**
74-
* @var AnchorRendererMock|\PHPUnit_Framework_MockObject_MockObject
74+
* @var AnchorRenderer|\PHPUnit_Framework_MockObject_MockObject
7575
*/
7676
private $anchorRendererMock;
7777

index.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
HTML;
3333
exit(1);
3434
}
35-
error_reporting(E_ALL);
36-
ini_set('display_errors', 1);
3735

3836
$bootstrap = \Magento\Framework\App\Bootstrap::create(BP, $_SERVER);
3937
/** @var \Magento\Framework\App\Http $app */

0 commit comments

Comments
 (0)