MAGETWO-33064: Implement obsolete test for refactored controllers

Author: Dooffy

dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteResponseTest.php

@@ -44,9 +44,10 @@ public function testObsoleteResponseMethods()
             function ($file) {
                 $content = file_get_contents($file);
                 foreach ($this->obsoleteMethods as $method) {
+                    $quotedMethod = preg_quote($method, '/');
                     $this->assertSame(
                         0,
-                        preg_match('/(?<=[a-z\d_:]|->|function\s)' . $method . '\s*\(/iS', $content),
+                        preg_match('/(?<=[a-z\d_:]|->|function\s)' . $quotedMethod . '\s*\(/iS', $content),
                         "File: $file\nContains obsolete method: $method . "
                     );
                 }
@@ -66,7 +67,8 @@ public function modulesFilesDataProvider()
 
         foreach ($this->getFilesData('whitelist/refactored_modules*') as $refactoredFolder) {
             $files = \Magento\Framework\Test\Utility\Files::init()->getFiles(
-                [$this->appPath . $refactoredFolder], '*.php'
+                [$this->appPath . $refactoredFolder],
+                '*.php'
             );
             $filesList = array_merge($filesList, $files);
         }