MAGETWO-33064: Implement obsolete test for refactored controllers

Author: Yurii Torbyk

app/code/Magento/Backend/Controller/Adminhtml/System/Store/DeleteStore.php

@@ -16,7 +16,6 @@ public function execute()
         $itemId = $this->getRequest()->getParam('item_id', null);
         if (!($model = $this->_objectManager->create('Magento\Store\Model\Store')->load($itemId))) {
             $this->messageManager->addError(__('Unable to proceed. Please, try again.'));
-            $this->_redirect('adminhtml/*/');
             /** @var \Magento\Backend\Model\View\Result\Redirect $redirectResult */
             $redirectResult = $this->resultRedirectFactory->create();
             return $redirectResult->setPath('adminhtml/*/');

app/code/Magento/Catalog/Controller/Category/View.php

@@ -52,6 +52,16 @@ class View extends \Magento\Framework\App\Action\Action
      */
     protected $resultPageFactory;
 
+    /**
+     * @var \Magento\Framework\Controller\Result\ForwardFactory
+     */
+    protected $resultForwardFactory;
+
+    /**
+     * @var \Magento\Framework\Controller\Result\RedirectFactory
+     */
+    protected $resultRedirectFactory;
+
     /**
      * Catalog Layer Resolver
      *
@@ -73,8 +83,10 @@ class View extends \Magento\Framework\App\Action\Action
      * @param \Magento\Framework\Registry $coreRegistry
      * @param \Magento\Framework\Store\StoreManagerInterface $storeManager
      * @param \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator $categoryUrlPathGenerator
-     * @param Resolver $layerResolver
      * @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
+     * @param \Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
+     * @param \Magento\Framework\Controller\Result\RedirectFactory $resultRedirectFactory
+     * @param Resolver $layerResolver
      * @param CategoryRepositoryInterface $categoryRepository
      */
     public function __construct(
@@ -85,6 +97,8 @@ public function __construct(
         \Magento\Framework\Store\StoreManagerInterface $storeManager,
         \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator $categoryUrlPathGenerator,
         PageFactory $resultPageFactory,
+        \Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory,
+        \Magento\Framework\Controller\Result\RedirectFactory $resultRedirectFactory,
         Resolver $layerResolver,
         CategoryRepositoryInterface $categoryRepository
     ) {
@@ -95,6 +109,8 @@ public function __construct(
         $this->_coreRegistry = $coreRegistry;
         $this->categoryUrlPathGenerator = $categoryUrlPathGenerator;
         $this->resultPageFactory = $resultPageFactory;
+        $this->resultForwardFactory = $resultForwardFactory;
+        $this->resultRedirectFactory = $resultRedirectFactory;
         $this->layerResolver = $layerResolver;
         $this->categoryRepository = $categoryRepository;
     }
@@ -137,15 +153,14 @@ protected function _initCategory()
     /**
      * Category view action
      *
-     * @return \Magento\Framework\View\Result\Page
+     * @return \Magento\Framework\Controller\ResultInterface
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function execute()
     {
         if ($this->_request->getParam(\Magento\Framework\App\Action\Action::PARAM_NAME_URL_ENCODED)) {
-            $this->getResponse()->setRedirect($this->_redirect->getRedirectUrl());
-            return;
+            return $this->resultRedirectFactory->create()->setUrl($this->_redirect->getRedirectUrl());
         }
         $category = $this->_initCategory();
         if ($category) {
@@ -192,7 +207,7 @@ public function execute()
             $page->getLayout()->initMessages();
             return $page;
         } elseif (!$this->getResponse()->isRedirect()) {
-            $this->_forward('noroute');
+            return $this->resultForwardFactory->create()->forward('noroute');
         }
     }
 }

dev/tests/static/testsuite/Magento/Test/Legacy/_files/response/blacklist/files_list.php

@@ -11,4 +11,8 @@
  */
 return [
     '/app/code/Magento/Backend/Model/View.php',
+    '/app/code/Magento/Backend/App/AbstractAction.php',
+    '/app/code/Magento/Backend/App/Response/Http/FileFactory.php',
+    '/app/code/Magento/Backend/Block/Widget.php',
+    '/app/code/Magento/Backend/Block/System/Config/Dwstree.php',
 ];