Merge branch 'ACP2E-184' of https://github.com/magento-l3/magento2ce into PR-2022-02-22

Author: Anna Bukatar

dev/tests/integration/testsuite/Magento/Framework/DB/HelperTest.php

@@ -46,7 +46,7 @@ public function testGetDateDiff()
     {
         $diff = $this->_model->getDateDiff('2011-01-01', '2011-01-01');
         $this->assertInstanceOf('Zend_Db_Expr', $diff);
-        $this->assertStringContainsString('TO_DAYS', (string)$diff);
+        $this->assertStringContainsString('TIMESTAMPDIFF(DAY', (string)$diff);
     }
 
     public function testAddLikeEscape()

lib/internal/Magento/Framework/DB/Helper.php

@@ -1,7 +1,5 @@
 <?php
 /**
- * DB helper class for MySql Magento DB Adapter
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
@@ -158,14 +156,8 @@ protected function _assembleLimit($query, $limitCount, $limitOffset, $columnList
     {
         if ($limitCount !== null) {
             $limitCount = (int)$limitCount;
-            if ($limitCount <= 0) {
-                //throw new \Exception("LIMIT argument count={$limitCount} is not valid");
-            }
 
             $limitOffset = (int)$limitOffset;
-            if ($limitOffset < 0) {
-                //throw new \Exception("LIMIT argument offset={$limitOffset} is not valid");
-            }
 
             if ($limitOffset + $limitCount != $limitOffset + 1) {
                 $columns = [];
@@ -275,7 +267,7 @@ public function addGroupConcatColumn(
      */
     public function getDateDiff($startDate, $endDate)
     {
-        $dateDiff = '(TO_DAYS(' . $endDate . ') - TO_DAYS(' . $startDate . '))';
+        $dateDiff = "TIMESTAMPDIFF(DAY, {$startDate}, {$endDate})";
         return new \Zend_Db_Expr($dateDiff);
     }