Skip to content

Commit a5b324f

Browse files
committed
ACP2E-184 : [Magento Cloud] Email reminders not being sent on correct schedule
1 parent 7934a7f commit a5b324f

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

dev/tests/integration/testsuite/Magento/Framework/DB/HelperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function testGetDateDiff()
4646
{
4747
$diff = $this->_model->getDateDiff('2011-01-01', '2011-01-01');
4848
$this->assertInstanceOf('Zend_Db_Expr', $diff);
49-
$this->assertStringContainsString('TO_DAYS', (string)$diff);
49+
$this->assertStringContainsString('TIMESTAMPDIFF(DAY', (string)$diff);
5050
}
5151

5252
public function testAddLikeEscape()

lib/internal/Magento/Framework/DB/Helper.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<?php
22
/**
3-
* DB helper class for MySql Magento DB Adapter
4-
*
53
* Copyright © Magento, Inc. All rights reserved.
64
* See COPYING.txt for license details.
75
*/
@@ -158,14 +156,8 @@ protected function _assembleLimit($query, $limitCount, $limitOffset, $columnList
158156
{
159157
if ($limitCount !== null) {
160158
$limitCount = (int)$limitCount;
161-
if ($limitCount <= 0) {
162-
//throw new \Exception("LIMIT argument count={$limitCount} is not valid");
163-
}
164159

165160
$limitOffset = (int)$limitOffset;
166-
if ($limitOffset < 0) {
167-
//throw new \Exception("LIMIT argument offset={$limitOffset} is not valid");
168-
}
169161

170162
if ($limitOffset + $limitCount != $limitOffset + 1) {
171163
$columns = [];
@@ -275,7 +267,7 @@ public function addGroupConcatColumn(
275267
*/
276268
public function getDateDiff($startDate, $endDate)
277269
{
278-
$dateDiff = "(TIMESTAMPDIFF(DAY, {$startDate}, {$endDate}))";
270+
$dateDiff = "TIMESTAMPDIFF(DAY, {$startDate}, {$endDate})";
279271
return new \Zend_Db_Expr($dateDiff);
280272
}
281273

0 commit comments

Comments
 (0)