Skip to content

Commit 69197f8

Browse files
authored
Use constructor property promotion in module WeeeGraphQl
Apply suggestions from code review
1 parent c8b2711 commit 69197f8

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

app/code/Magento/WeeeGraphQl/Model/Resolver/FixedProductTax.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class FixedProductTax implements ResolverInterface
2626
* @param TaxHelper $taxHelper
2727
*/
2828
public function __construct(
29-
private Data $weeeHelper,
30-
private TaxHelper $taxHelper
29+
private readonly Data $weeeHelper,
30+
private readonly TaxHelper $taxHelper
3131
) {
3232
}
3333

app/code/Magento/WeeeGraphQl/Model/Resolver/Quote/FixedProductTax.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class FixedProductTax implements ResolverInterface
2626
* @param TaxHelper $taxHelper
2727
*/
2828
public function __construct(
29-
private Data $weeeHelper,
30-
private TaxHelper $taxHelper
29+
private readonly Data $weeeHelper,
30+
private readonly TaxHelper $taxHelper
3131
) {
3232
}
3333

app/code/Magento/WeeeGraphQl/Model/Resolver/StoreConfig.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ class StoreConfig implements ResolverInterface
4646
* @param TaxHelper $taxHelper
4747
*/
4848
public function __construct(
49-
private Data $weeeHelper,
50-
private TaxHelper $taxHelper
49+
private readonly Data $weeeHelper,
50+
private readonly TaxHelper $taxHelper
5151
) {
5252
}
5353

0 commit comments

Comments
 (0)