Skip to content

Commit c8b2711

Browse files
Use constructor property promotion in module WeeeGraphQl
Replace allmost all properties with constructor property promotion in module WeeeGraphQl: https://stitcher.io/blog/constructor-promotion-in-php-8 * Readable code * Make Magento less complex by removing properties which take up a lot of lines. * Imported all classes to make code more readable. I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).
1 parent 6f1107c commit c8b2711

File tree

4 files changed

+17
-43
lines changed

4 files changed

+17
-43
lines changed

app/code/Magento/WeeeGraphQl/Model/Resolver/FixedProductTax.php

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,14 @@
2121
*/
2222
class FixedProductTax implements ResolverInterface
2323
{
24-
/**
25-
* @var Data
26-
*/
27-
private $weeeHelper;
28-
29-
/**
30-
* @var TaxHelper
31-
*/
32-
private $taxHelper;
33-
3424
/**
3525
* @param Data $weeeHelper
3626
* @param TaxHelper $taxHelper
3727
*/
38-
public function __construct(Data $weeeHelper, TaxHelper $taxHelper)
39-
{
40-
$this->weeeHelper = $weeeHelper;
41-
$this->taxHelper = $taxHelper;
28+
public function __construct(
29+
private Data $weeeHelper,
30+
private TaxHelper $taxHelper
31+
) {
4232
}
4333

4434
/**

app/code/Magento/WeeeGraphQl/Model/Resolver/Quote/FixedProductTax.php

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,14 @@
2121
*/
2222
class FixedProductTax implements ResolverInterface
2323
{
24-
/**
25-
* @var Data
26-
*/
27-
private $weeeHelper;
28-
29-
/**
30-
* @var TaxHelper
31-
*/
32-
private $taxHelper;
33-
3424
/**
3525
* @param Data $weeeHelper
3626
* @param TaxHelper $taxHelper
3727
*/
38-
public function __construct(Data $weeeHelper, TaxHelper $taxHelper)
39-
{
40-
$this->weeeHelper = $weeeHelper;
41-
$this->taxHelper = $taxHelper;
28+
public function __construct(
29+
private Data $weeeHelper,
30+
private TaxHelper $taxHelper
31+
) {
4232
}
4333

4434
/**

app/code/Magento/WeeeGraphQl/Model/Resolver/StoreConfig.php

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,6 @@ class StoreConfig implements ResolverInterface
3636
WeeeDisplayConfig::DISPLAY_EXCL => 'EXCLUDE_FPT_WITHOUT_DETAILS'
3737
];
3838

39-
/**
40-
* @var Data
41-
*/
42-
private $weeeHelper;
43-
44-
/**
45-
* @var TaxHelper
46-
*/
47-
private $taxHelper;
48-
4939
/**
5040
* @var array
5141
*/
@@ -55,10 +45,10 @@ class StoreConfig implements ResolverInterface
5545
* @param Data $weeeHelper
5646
* @param TaxHelper $taxHelper
5747
*/
58-
public function __construct(Data $weeeHelper, TaxHelper $taxHelper)
59-
{
60-
$this->weeeHelper = $weeeHelper;
61-
$this->taxHelper = $taxHelper;
48+
public function __construct(
49+
private Data $weeeHelper,
50+
private TaxHelper $taxHelper
51+
) {
6252
}
6353

6454
/**

app/code/Magento/WeeeGraphQl/registration.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,8 @@
66

77
use Magento\Framework\Component\ComponentRegistrar;
88

9-
ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_WeeeGraphQl', __DIR__);
9+
ComponentRegistrar::register(
10+
ComponentRegistrar::MODULE,
11+
'Magento_WeeeGraphQl',
12+
__DIR__
13+
);

0 commit comments

Comments
 (0)