MAGETWO-32872: Create pull request for S45 Controller Refactoring

Dooffy · Dooffy · commit 67db6647d473 · 2015-01-26T13:32:17.000+02:00
diff --git a/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php b/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php
@@ -44,6 +44,7 @@ public function __construct(
      * @return void|\Magento\Framework\Controller\Result\Forward
      *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.ExitExpression)
      */
     public function execute()
     {
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php
@@ -7,7 +7,7 @@
 
 /**
  * Class ViewTest
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.TooManyFields)
  */
 class ViewTest extends \PHPUnit_Framework_TestCase
 {
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/ViewTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/ViewTest.php
@@ -7,6 +7,7 @@
 
 /**
  * @covers \Magento\Sales\Controller\Adminhtml\Order\View
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ViewTest extends \PHPUnit_Framework_TestCase
 {

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ public function __construct(`
`44`	`44`	`* @return void\|\Magento\Framework\Controller\Result\Forward`
`45`	`45`	`*`
`46`	`46`	`* @SuppressWarnings(PHPMD.CyclomaticComplexity)`
	`47`	`+ * @SuppressWarnings(PHPMD.ExitExpression)`
`47`	`48`	`*/`
`48`	`49`	`public function execute()`
`49`	`50`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`/**`
`9`	`9`	`* Class ViewTest`
`10`		`- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)`
	`10`	`+ * @SuppressWarnings(PHPMD.TooManyFields)`
`11`	`11`	`*/`
`12`	`12`	`class ViewTest extends \PHPUnit_Framework_TestCase`
`13`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`
`8`	`8`	`/**`
`9`	`9`	`* @covers \Magento\Sales\Controller\Adminhtml\Order\View`
	`10`	`+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)`
`10`	`11`	`*/`
`11`	`12`	`class ViewTest extends \PHPUnit_Framework_TestCase`
`12`	`13`	`{`