MAGETWO-32872: Create pull request for S45 Controller Refactoring

Author: Dooffy

app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php

@@ -40,7 +40,7 @@ protected function _isAllowed()
     public function execute()
     {
         $resultForward = $this->resultForwardFactory->create();
-        if ($creditmemoId = $this->getRequest()->getParam('creditmemo_id')) {
+        if ($this->getRequest()->getParam('creditmemo_id')) {
             $resultForward->setController('order_creditmemo');
             $resultForward->setParams(['come_from' => 'sales_creditmemo']);
             $resultForward->forward('view');

app/code/Magento/Sales/Controller/Adminhtml/Order/CommentsHistory.php

@@ -26,6 +26,8 @@ class CommentsHistory extends \Magento\Sales\Controller\Adminhtml\Order
      * @param \Magento\Framework\View\Result\LayoutFactory $resultLayoutFactory
      * @param \Magento\Framework\Controller\Result\RawFactory $resultRawFactory
      * @param \Magento\Framework\View\LayoutFactory $layoutFactory
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         Action\Context $context,

app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php

@@ -11,6 +11,8 @@ class Save extends \Magento\Sales\Controller\Adminhtml\Order\Create
      * Saving quote and create order
      *
      * @return \Magento\Backend\Model\View\Result\Forward|\Magento\Backend\Model\View\Result\Redirect
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function execute()
     {

app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php

@@ -65,6 +65,9 @@ protected function _isAllowed()
      * We can save only new creditmemo. Existing creditmemos are not editable
      *
      * @return \Magento\Backend\Model\View\Result\Redirect|\Magento\Backend\Model\View\Result\Forward
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function execute()
     {

app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php

@@ -104,6 +104,10 @@ protected function _prepareShipment($invoice)
      * We can save only new invoice. Existing invoices are not editable
      *
      * @return \Magento\Framework\Controller\ResultInterface
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function execute()
     {

app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php

@@ -14,6 +14,8 @@ class Pdfdocs extends \Magento\Sales\Controller\Adminhtml\Order
      * Print all documents for selected orders
      *
      * @return ResponseInterface|\Magento\Backend\Model\View\Result\Redirect
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function execute()
     {

app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php

@@ -45,7 +45,7 @@ public function execute()
     {
         /** @var \Magento\Backend\Model\View\Result\Forward $resultForward */
         $resultForward = $this->resultForwardFactory->create();
-        if ($shipmentId = $this->getRequest()->getParam('shipment_id')) {
+        if ($this->getRequest()->getParam('shipment_id')) {
             $resultForward->setController('order_shipment')
                 ->setModule('admin')
                 ->setParams(['come_from' => 'shipment'])

app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php

@@ -42,6 +42,8 @@ public function __construct(
      * Custom options download action
      *
      * @return void|\Magento\Framework\Controller\Result\Forward
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function execute()
     {

dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php

@@ -14,6 +14,7 @@
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.TooManyFields)
  */
 class ConfirmTest extends \PHPUnit_Framework_TestCase
 {

dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Invoice/AbstractInvoice/EmailTest.php

@@ -13,6 +13,7 @@
  * Class EmailTest
  *
  * @package Magento\Sales\Controller\Adminhtml\Invoice\AbstractInvoice
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class EmailTest extends \PHPUnit_Framework_TestCase
 {
@@ -85,7 +86,7 @@ public function setUp()
     {
         $objectManagerHelper = new ObjectManagerHelper($this);
         $this->context = $this->getMock('Magento\Backend\App\Action\Context', [], [], '', false);
-        $this->response = $this->getMock('Magento\Framework\App\ResponseInterface', [], [], '', false );
+        $this->response = $this->getMock('Magento\Framework\App\ResponseInterface', [], [], '', false);
         $this->request = $this->getMock('Magento\Framework\App\RequestInterface', [], [], '', false);
         $this->objectManager = $this->getMock('Magento\Framework\ObjectManager\ObjectManager', [], [], '', false);
         $this->messageManager = $this->getMock('Magento\Framework\Message\Manager', [], [], '', false);