optimize 2 nested if to one

likemusic · likemusic · commit 65e9395f5d17 · 2018-05-06T00:10:09.000+03:00
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php
@@ -29,11 +29,8 @@ public function prepareProductAttributes(Product $product, array $productData, a
     {
         foreach ($productData as $attribute => $value) {
             $considerUseDefaultsAttribute = !isset($useDefaults[$attribute]) || $useDefaults[$attribute] === "1";
-            if ($value === '' && $considerUseDefaultsAttribute) {
-                /** @var $product Product */
-                if ((bool)$product->getData($attribute) === false) {
-                    unset($productData[$attribute]);
-                }
+            if ($value === '' && $considerUseDefaultsAttribute && !$product->getData($attribute)) {
+                unset($productData[$attribute]);
             }
         }
         return $productData;

Original file line number	Diff line number	Diff line change
`@@ -29,11 +29,8 @@ public function prepareProductAttributes(Product $product, array $productData, a`
`29`	`29`	`{`
`30`	`30`	`foreach ($productData as $attribute => $value) {`
`31`	`31`	`$considerUseDefaultsAttribute = !isset($useDefaults[$attribute]) \|\| $useDefaults[$attribute] === "1";`
`32`		`- if ($value === '' && $considerUseDefaultsAttribute) {`
`33`		`- /** @var $product Product */`
`34`		`- if ((bool)$product->getData($attribute) === false) {`
`35`		`- unset($productData[$attribute]);`
`36`		`- }`
	`32`	`+ if ($value === '' && $considerUseDefaultsAttribute && !$product->getData($attribute)) {`
	`33`	`+ unset($productData[$attribute]);`
`37`	`34`	`}`
`38`	`35`	`}`
`39`	`36`	`return $productData;`