small optimisation in if-condition

likemusic · likemusic · commit 8a0432dee967 · 2018-05-04T22:07:18.000+03:00
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php
@@ -31,7 +31,7 @@ public function prepareProductAttributes(Product $product, array $productData, a
             $considerUseDefaultsAttribute = !isset($useDefaults[$attribute]) || $useDefaults[$attribute] === "1";
             if ($value === '' && $considerUseDefaultsAttribute) {
                 /** @var $product Product */
-                if ((bool)$product->getData($attribute) === (bool)$value) {
+                if ((bool)$product->getData($attribute) === false) {
                     unset($productData[$attribute]);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function prepareProductAttributes(Product $product, array $productData, a`
`31`	`31`	`$considerUseDefaultsAttribute = !isset($useDefaults[$attribute]) \|\| $useDefaults[$attribute] === "1";`
`32`	`32`	`if ($value === '' && $considerUseDefaultsAttribute) {`
`33`	`33`	`/** @var $product Product */`
`34`		`- if ((bool)$product->getData($attribute) === (bool)$value) {`
	`34`	`+ if ((bool)$product->getData($attribute) === false) {`
`35`	`35`	`unset($productData[$attribute]);`
`36`	`36`	`}`
`37`	`37`	`}`