AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit 6235b5d9e864 · 2025-01-31T19:31:22.000+05:30
Better way to fix rounding error is to typecast to string instead of float which works both in 8.3 &amp; 8.4
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -152,11 +152,7 @@ protected function getStore($scope = null)
      */
     public function round($price)
     {
-        // To fix rounding error in PHP 8.4
-        if (str_contains(PHP_VERSION, '8.4')) {
-            return round(round((float) $price, 3), 2);
-        }
-        return round((float) $price, 2);
+        return round((string) $price, 2);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -152,11 +152,7 @@ protected function getStore($scope = null)`
`152`	`152`	`*/`
`153`	`153`	`public function round($price)`
`154`	`154`	`{`
`155`		`- // To fix rounding error in PHP 8.4`
`156`		`- if (str_contains(PHP_VERSION, '8.4')) {`
`157`		`- return round(round((float) $price, 3), 2);`
`158`		`- }`
`159`		`- return round((float) $price, 2);`
	`155`	`+ return round((string) $price, 2);`
`160`	`156`	`}`
`161`	`157`
`162`	`158`	`/**`