AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit e66b9beefa2b · 2025-01-31T19:31:22.000+05:30
To fix rounding error in PHP 8.4
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -153,7 +153,10 @@ protected function getStore($scope = null)
     public function round($price)
     {
         // To fix rounding error in PHP 8.4
-        return round(round((float) $price, 3), 2);
+        if (str_contains(PHP_VERSION, '8.4')) {
+            return round(round((float) $price, 3), 2);
+        }
+        return round((float) $price, 2);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,10 @@ protected function getStore($scope = null)`
`153`	`153`	`public function round($price)`
`154`	`154`	`{`
`155`	`155`	`// To fix rounding error in PHP 8.4`
`156`		`- return round(round((float) $price, 3), 2);`
	`156`	`+ if (str_contains(PHP_VERSION, '8.4')) {`
	`157`	`+ return round(round((float) $price, 3), 2);`
	`158`	`+ }`
	`159`	`+ return round((float) $price, 2);`
`157`	`160`	`}`
`158`	`161`
`159`	`162`	`/**`