Skip to content

Commit 5d2cf66

Browse files
Pooja.ManralPooja.Manral
authored andcommitted
AC-9843:: i18n:collect-phrases breaks the translations integrity
1 parent 05ee892 commit 5d2cf66

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

lib/internal/Magento/Framework/Config/Test/Unit/Composer/PackageTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
class PackageTest extends TestCase
1414
{
15-
public const SAMPLE_DATA =
15+
const SAMPLE_DATA =
1616
'{"foo":"1","bar":"2","baz":["3","4"],"nested":{"one":"5","two":"6",
1717
"magento/theme-adminhtml-backend":7, "magento/theme-frontend-luma":8}}';
1818

@@ -49,10 +49,10 @@ public function testGet()
4949
$this->assertSame(['3', '4'], $this->object->get('baz'));
5050
$nested = $this->object->get('nested');
5151
$this->assertInstanceOf('\StdClass', $nested);
52-
$this->assertObjectHasProperty('one', $nested);
52+
$this->assertObjectHasAttribute('one', $nested);
5353
$this->assertEquals('5', $nested->one);
5454
$this->assertEquals('5', $this->object->get('nested->one'));
55-
$this->assertObjectHasProperty('two', $nested);
55+
$this->assertObjectHasAttribute('two', $nested);
5656
$this->assertEquals('6', $nested->two);
5757
$this->assertEquals('6', $this->object->get('nested->two'));
5858
$this->assertEquals(

lib/internal/Magento/Framework/Simplexml/Test/Unit/ElementTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ public function testUnsetSelf($xmlData)
1919
{
2020
/** @var Element $xml */
2121
$xml = simplexml_load_file($xmlData[0], $xmlData[1]);
22-
$this->assertObjectHasProperty('node4', $xml->node3);
22+
$this->assertObjectHasAttribute('node4', $xml->node3);
2323
$xml->node3->unsetSelf();
24-
$this->assertObjectNotHasProperty('node4', $xml->node3);
25-
$this->assertObjectNotHasProperty('node3', $xml);
26-
$this->assertObjectHasProperty('node1', $xml);
24+
$this->assertObjectNotHasAttribute('node4', $xml->node3);
25+
$this->assertObjectNotHasAttribute('node3', $xml);
26+
$this->assertObjectHasAttribute('node1', $xml);
2727
}
2828

2929
/**

0 commit comments

Comments
 (0)