AC-9843:: i18n:collect-phrases breaks the translations integrity

Poojamanral123 · Poojamanral123 · commit 05ee8920d6b6 · 2024-05-07T18:16:29.000+05:30
diff --git a/dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/TranslationFilesTest.php b/dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/TranslationFilesTest.php
@@ -17,7 +17,7 @@
 class TranslationFilesTest extends TranslationFiles
 {
     /**
-     * Context var
+     * I18n\Context
      *
      * @var \Magento\Setup\Module\I18n\Context
      */
diff --git a/lib/internal/Magento/Framework/Config/Test/Unit/Composer/PackageTest.php b/lib/internal/Magento/Framework/Config/Test/Unit/Composer/PackageTest.php
@@ -12,7 +12,7 @@
 
 class PackageTest extends TestCase
 {
-    private const SAMPLE_DATA =
+    public const SAMPLE_DATA =
         '{"foo":"1","bar":"2","baz":["3","4"],"nested":{"one":"5","two":"6",
         "magento/theme-adminhtml-backend":7, "magento/theme-frontend-luma":8}}';
 
diff --git a/setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Js.php b/setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Js.php
@@ -11,7 +11,7 @@
 /**
  * Js parser adapter
  */
-#[\AllowDynamicProperties]
+
 class Js extends AbstractAdapter
 {
     /**
diff --git a/setup/src/Magento/Setup/Module/I18n/ServiceLocator.php b/setup/src/Magento/Setup/Module/I18n/ServiceLocator.php
@@ -28,14 +28,14 @@ class ServiceLocator
     private static $_context;
 
     /**
-     * Dictionary generators
+     * I18n Dictionary generator
      *
      * @var \Magento\Setup\Module\I18n\Dictionary\Generator
      */
     private static $_dictionaryGenerator;
 
     /**
-     * Pack generators
+     * I18n Pack generator
      *
      * @var \Magento\Setup\Module\I18n\Pack\Generator
      */

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`class TranslationFilesTest extends TranslationFiles`
`18`	`18`	`{`
`19`	`19`	`/**`
`20`		`- * Context var`
	`20`	`+ * I18n\Context`
`21`	`21`	`*`
`22`	`22`	`* @var \Magento\Setup\Module\I18n\Context`
`23`	`23`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`
`13`	`13`	`class PackageTest extends TestCase`
`14`	`14`	`{`
`15`		`- private const SAMPLE_DATA =`
	`15`	`+ public const SAMPLE_DATA =`
`16`	`16`	`'{"foo":"1","bar":"2","baz":["3","4"],"nested":{"one":"5","two":"6",`
`17`	`17`	`"magento/theme-adminhtml-backend":7, "magento/theme-frontend-luma":8}}';`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`/**`
`12`	`12`	`* Js parser adapter`
`13`	`13`	`*/`
`14`		`-#[\AllowDynamicProperties]`
	`14`	`+`
`15`	`15`	`class Js extends AbstractAdapter`
`16`	`16`	`{`
`17`	`17`	`/**`