ACP2E-2847: Favicon upload fails to validate .ico files

Chhandak.Barua · Chhandak.Barua · commit 552a6444d804 · 2024-03-03T04:16:37.000+05:30
diff --git a/dev/tests/integration/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeControllerTest.php b/dev/tests/integration/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeControllerTest.php
@@ -11,6 +11,7 @@
 
 /**
  * @magentoAppArea adminhtml
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
  */
 class ThemeControllerTest extends \Magento\TestFramework\TestCase\AbstractBackendController
 {
@@ -50,12 +51,6 @@ public function testUploadJsAction()
         $this->assertStringContainsString($name, $output);
     }
 
-    /**
-     * testing uploaded favicon file
-     *
-     * @throws FileSystemException
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     */
     public function testUploadFaviconAction()
     {
         $names = ['favicon-x-icon.ico', 'favicon-vnd-microsoft.ico'];

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`
`12`	`12`	`/**`
`13`	`13`	`* @magentoAppArea adminhtml`
	`14`	`+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
`14`	`15`	`*/`
`15`	`16`	`class ThemeControllerTest extends \Magento\TestFramework\TestCase\AbstractBackendController`
`16`	`17`	`{`
`@@ -50,12 +51,6 @@ public function testUploadJsAction()`
`50`	`51`	`$this->assertStringContainsString($name, $output);`
`51`	`52`	`}`
`52`	`53`
`53`		`- /**`
`54`		`- * testing uploaded favicon file`
`55`		`- *`
`56`		`- * @throws FileSystemException`
`57`		`- * @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
`58`		`- */`
`59`	`54`	`public function testUploadFaviconAction()`
`60`	`55`	`{`
`61`	`56`	`$names = ['favicon-x-icon.ico', 'favicon-vnd-microsoft.ico'];`