ACP2E-2847: Favicon upload fails to validate .ico files

Chhandak.Barua · Chhandak.Barua · commit 251020ae4ffb · 2024-03-03T02:27:24.000+05:30
diff --git a/dev/tests/integration/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeControllerTest.php b/dev/tests/integration/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeControllerTest.php
@@ -50,6 +50,12 @@ public function testUploadJsAction()
         $this->assertStringContainsString($name, $output);
     }
 
+    /**
+     * testing uploaded favicon file
+     *
+     * @throws FileSystemException
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     */
     public function testUploadFaviconAction()
     {
         $names = ['favicon-x-icon.ico', 'favicon-vnd-microsoft.ico'];

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,12 @@ public function testUploadJsAction()`
`50`	`50`	`$this->assertStringContainsString($name, $output);`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ /**`
	`54`	`+ * testing uploaded favicon file`
	`55`	`+ *`
	`56`	`+ * @throws FileSystemException`
	`57`	`+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
	`58`	`+ */`
`53`	`59`	`public function testUploadFaviconAction()`
`54`	`60`	`{`
`55`	`61`	`$names = ['favicon-x-icon.ico', 'favicon-vnd-microsoft.ico'];`