[EngCom] Public Pull Requests - 2.3-develop

 - merged latest code from mainline branch

Author: magento-engcom-team

app/code/Magento/ReleaseNotification/Ui/DataProvider/Modifier/Notifications.php

@@ -192,9 +192,9 @@ private function hideNotification(array $meta)
      */
     private function getNotificationContent()
     {
-        $version = $this->getTargetVersion();
-        $edition = $this->productMetadata->getEdition();
-        $locale = $this->session->getUser()->getInterfaceLocale();
+        $version = strtolower($this->getTargetVersion());
+        $edition = strtolower($this->productMetadata->getEdition());
+        $locale = strtolower($this->session->getUser()->getInterfaceLocale());
 
         $cacheKey = self::$cachePrefix . $version . "-" . $edition . "-" . $locale;
         $modalContent = $this->cacheStorage->load($cacheKey);

app/code/Magento/ReleaseNotification/etc/config.xml

@@ -9,7 +9,7 @@
     <default>
         <system>
             <release_notification>
-                <content_url>raw.githubusercontent.com/magento-arcticfoxes/release-notification/master</content_url>
+                <content_url>magento.com/release_notifications</content_url>
                 <use_https>1</use_https>
             </release_notification>
         </system>

app/code/Magento/Ui/view/base/web/js/form/element/url-input.js

@@ -133,7 +133,7 @@ define([
         createChildUrlInputComponent: function (value) {
             var elementConfig;
 
-            if (_.isUndefined(this.linkedElementInstances[value])) {
+            if (!_.isEmpty(value) && _.isUndefined(this.linkedElementInstances[value])) {
                 elementConfig = this.urlTypes[value];
                 layout([elementConfig]);
                 this.linkedElementInstances[value] = this.requestModule(elementConfig.name);

app/code/Magento/Ui/view/base/web/js/lib/key-codes.js

@@ -20,6 +20,9 @@ define([], function () {
         39: 'pageRightKey',
         17: 'ctrlKey',
         18: 'altKey',
-        16: 'shiftKey'
+        16: 'shiftKey',
+        66: 'bKey',
+        73: 'iKey',
+        85: 'uKey'
     };
 });

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Customer/Test/AdminCreateCustomerTest.xml

@@ -18,6 +18,7 @@
             <testCaseId value="MAGETWO-72095"/>
             <group value="customer"/>
             <group value="create"/>
+            <group value="skip"/>
         </annotations>
         <after>
             <amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>

lib/web/jquery/jstree/jquery.hotkeys.js

@@ -48,8 +48,12 @@
 
 		handleObj.handler = function( event ) {
 			// Don't fire in text-accepting inputs that we didn't directly bind to
+            /**
+             * Modified by Magento to ensure it doesn't fire on any content editable areas. This library is no
+             * longer maintained by its author however we require content editable to behave as expected.
+             */
 			if ( this !== event.target && (/textarea|select/i.test( event.target.nodeName ) ||
-				 event.target.type === "text") ) {
+				 event.target.type === "text" || jQuery(event.target).attr('contenteditable')) ) {
 				return;
 			}