Skip to content

Commit c804fc0

Browse files
authored
Merge pull request #2308 from magento-obsessive-owls/cms-team-1-delivery-sprint-4
[CMS Team 1] Sprint 4
2 parents 329f672 + bd6e696 commit c804fc0

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

app/code/Magento/Ui/view/base/web/js/form/element/url-input.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ define([
133133
createChildUrlInputComponent: function (value) {
134134
var elementConfig;
135135

136-
if (_.isUndefined(this.linkedElementInstances[value])) {
136+
if (!_.isEmpty(value) && _.isUndefined(this.linkedElementInstances[value])) {
137137
elementConfig = this.urlTypes[value];
138138
layout([elementConfig]);
139139
this.linkedElementInstances[value] = this.requestModule(elementConfig.name);

app/code/Magento/Ui/view/base/web/js/lib/key-codes.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ define([], function () {
2020
39: 'pageRightKey',
2121
17: 'ctrlKey',
2222
18: 'altKey',
23-
16: 'shiftKey'
23+
16: 'shiftKey',
24+
66: 'bKey',
25+
73: 'iKey',
26+
85: 'uKey'
2427
};
2528
});

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Customer/Test/AdminCreateCustomerTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<testCaseId value="MAGETWO-72095"/>
1919
<group value="customer"/>
2020
<group value="create"/>
21+
<group value="skip"/>
2122
</annotations>
2223
<after>
2324
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>

lib/web/jquery/jstree/jquery.hotkeys.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,12 @@
4848

4949
handleObj.handler = function( event ) {
5050
// Don't fire in text-accepting inputs that we didn't directly bind to
51+
/**
52+
* Modified by Magento to ensure it doesn't fire on any content editable areas. This library is no
53+
* longer maintained by its author however we require content editable to behave as expected.
54+
*/
5155
if ( this !== event.target && (/textarea|select/i.test( event.target.nodeName ) ||
52-
event.target.type === "text") ) {
56+
event.target.type === "text" || jQuery(event.target).attr('contenteditable')) ) {
5357
return;
5458
}
5559

0 commit comments

Comments
 (0)