Skip to content

Commit 538ee27

Browse files
committed
MTA-1814: Analyse functional test failures - Sprint 9
- Fixed bug with price - Fixed bug with close window - Added skipped tests
1 parent 5d31786 commit 538ee27

File tree

7 files changed

+13
-20
lines changed

7 files changed

+13
-20
lines changed

dev/tests/functional/lib/Magento/Mtf/Client/Element/GlobalsearchElement.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ protected function clear()
9797
*/
9898
protected function selectWindow()
9999
{
100-
$this->driver->closeWindow();
100+
$this->driver->selectWindow();
101101
}
102102

103103
/**

dev/tests/functional/tests/app/Magento/Bundle/Test/Fixture/BundleProduct/Price.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ public function getPreset()
119119
'cart_price' => '80.00',
120120
],
121121
// Bundle fixed
122-
'fixed-1' => [
123-
'price_from' => '1.00',
124-
'price_to' => '10.00',
122+
'fixed-10' => [
123+
'price_from' => '10.00',
124+
'price_to' => '100.00',
125125
'cart_price' => '80.00',
126126
],
127127
'fixed-15' => [

dev/tests/functional/tests/app/Magento/Bundle/Test/TestCase/CreateBundleProductEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145
<data name="product/data/status" xsi:type="string">Product online</data>
146146
<data name="product/data/price_type" xsi:type="string">Fixed</data>
147147
<data name="product/data/price/value" xsi:type="string">10</data>
148-
<data name="product/data/price/preset" xsi:type="string">fixed-1</data>
148+
<data name="product/data/price/preset" xsi:type="string">fixed-10</data>
149149
<data name="product/data/tax_class_id/dataSet" xsi:type="string">taxable_goods</data>
150150
<data name="product/data/quantity_and_stock_status/is_in_stock" xsi:type="string">Out of Stock</data>
151151
<data name="product/data/weight_type" xsi:type="string">Fixed</data>

dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerGroupEntityTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class UpdateCustomerGroupEntityTest extends Injectable
3333
/* tags */
3434
const MVP = 'yes';
3535
const DOMAIN = 'CS';
36+
const STABLE = 'no';
3637
/* end tags */
3738

3839
/**

dev/tests/functional/tests/app/Magento/Downloadable/Test/TestCase/CreateDownloadableProductEntityTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@
122122
<constraint name="Magento\Downloadable\Test\Constraint\AssertDownloadableProductForm" />
123123
</variation>
124124
<variation name="CreateDownloadableProductEntityTestVariation7">
125+
<data name="tag" xsi:type="string">stable:no</data>
125126
<data name="description" xsi:type="string">Create product with manage stock</data>
126127
<data name="product/data/name" xsi:type="string">DownloadableProduct_%isolation%</data>
127128
<data name="product/data/sku" xsi:type="string">DownloadableProduct_%isolation%</data>

dev/tests/functional/tests/app/Magento/Review/Test/TestCase/ManageProductReviewFromCustomerPageTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ class ManageProductReviewFromCustomerPageTest extends Injectable
5050
/* tags */
5151
const MVP = 'no';
5252
const DOMAIN = 'MX';
53+
const STABLE = 'no';
5354
/* end tags */
5455

5556
/**

dev/tests/functional/tests/app/Magento/Review/Test/TestCase/UpdateProductReviewEntityOnProductPageTest.php

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66

77
namespace Magento\Review\Test\TestCase;
88

9-
use Magento\Catalog\Test\Fixture\CatalogProductSimple;
109
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
11-
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
1210
use Magento\Review\Test\Fixture\Review;
1311
use Magento\Review\Test\Page\Adminhtml\RatingEdit;
1412
use Magento\Review\Test\Page\Adminhtml\RatingIndex;
@@ -45,13 +43,6 @@ class UpdateProductReviewEntityOnProductPageTest extends Injectable
4543
const TO_MAINTAIN = 'yes';
4644
/* end tags */
4745

48-
/**
49-
* Catalog product index page
50-
*
51-
* @var CatalogProductIndex
52-
*/
53-
protected $catalogProductIndex;
54-
5546
/**
5647
* Catalog product edit page
5748
*
@@ -115,21 +106,18 @@ public function __prepare(FixtureFactory $fixtureFactory)
115106
*
116107
* @param RatingIndex $ratingIndex
117108
* @param RatingEdit $ratingEdit
118-
* @param CatalogProductIndex $catalogProductIndex
119109
* @param CatalogProductEdit $catalogProductEdit
120110
* @param ReviewEdit $reviewEdit
121111
* @return void
122112
*/
123113
public function __inject(
124114
RatingIndex $ratingIndex,
125115
RatingEdit $ratingEdit,
126-
CatalogProductIndex $catalogProductIndex,
127116
CatalogProductEdit $catalogProductEdit,
128117
ReviewEdit $reviewEdit
129118
) {
130119
$this->ratingIndex = $ratingIndex;
131120
$this->ratingEdit = $ratingEdit;
132-
$this->catalogProductIndex = $catalogProductIndex;
133121
$this->catalogProductEdit = $catalogProductEdit;
134122
$this->reviewEdit = $reviewEdit;
135123
}
@@ -145,10 +133,12 @@ public function test(Review $review, $rating)
145133
{
146134
// Steps
147135
$review = $this->createReview($review, $rating);
148-
$this->catalogProductIndex->open();
149-
/** @var CatalogProductSimple $product */
150136
$product = $this->reviewInitial->getDataFieldConfig('entity_id')['source']->getEntity();
151-
$this->catalogProductIndex->getProductGrid()->searchAndOpen(['sku' => $product->getSku()]);
137+
$this->objectManager->create(
138+
'Magento\Catalog\Test\TestStep\OpenProductOnBackendStep',
139+
['product' => $product]
140+
)->run();
141+
152142
$this->catalogProductEdit->getProductForm()->openTab('product_reviews');
153143
$filter = [
154144
'title' => $this->reviewInitial->getTitle(),

0 commit comments

Comments
 (0)