MTA-1814: Analyse functional test failures - Sprint 9

Author: Dmytro Aponasenko

dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerFrontendEntityTest.php

@@ -12,13 +12,11 @@
 use Magento\Customer\Test\Fixture\Customer;
 use Magento\Customer\Test\Page\CustomerAccountEdit;
 use Magento\Customer\Test\Page\CustomerAccountIndex;
-use Magento\Customer\Test\Page\CustomerAccountLogin;
 use Magento\Customer\Test\Page\CustomerAddressEdit;
 use Magento\Mtf\Fixture\FixtureFactory;
 use Magento\Mtf\TestCase\Injectable;
 
 /**
- * Test Flow:
  * Preconditions:
  * 1. Default test customer is created
  *
@@ -58,13 +56,6 @@ class UpdateCustomerFrontendEntityTest extends Injectable
      */
     protected $cmsIndex;
 
-    /**
-     * CustomerAccountLogin page
-     *
-     * @var CustomerAccountLogin
-     */
-    protected $customerAccountLogin;
-
     /**
      * CustomerAccountIndex page
      *
@@ -91,7 +82,6 @@ class UpdateCustomerFrontendEntityTest extends Injectable
      *
      * @param CmsIndex $cmsIndex
      * @param FixtureFactory $fixtureFactory
-     * @param CustomerAccountLogin $customerAccountLogin
      * @param CustomerAccountIndex $customerAccountIndex
      * @param CustomerAccountEdit $customerAccountEdit
      * @param CustomerAddressEdit $customerAddressEdit
@@ -100,14 +90,12 @@ class UpdateCustomerFrontendEntityTest extends Injectable
     public function __inject(
         CmsIndex $cmsIndex,
         FixtureFactory $fixtureFactory,
-        CustomerAccountLogin $customerAccountLogin,
         CustomerAccountIndex $customerAccountIndex,
         CustomerAccountEdit $customerAccountEdit,
         CustomerAddressEdit $customerAddressEdit
     ) {
         $this->cmsIndex = $cmsIndex;
         $this->fixtureFactory = $fixtureFactory;
-        $this->customerAccountLogin = $customerAccountLogin;
         $this->customerAccountIndex = $customerAccountIndex;
         $this->customerAccountEdit = $customerAccountEdit;
         $this->customerAddressEdit = $customerAddressEdit;
@@ -132,12 +120,10 @@ public function test(
         $initialCustomer->persist();
 
         // Steps
-        $this->cmsIndex->open();
-        $this->cmsIndex->getLinksBlock()->openLink('Log In');
-        sleep(3);
-        $this->customerAccountLogin->getLoginBlock()->fill($initialCustomer);
-        $this->customerAccountLogin->getLoginBlock()->submit();
-
+        $this->objectManager->create(
+            'Magento\Customer\Test\TestStep\LoginCustomerOnFrontendStep',
+            ['customer' => $initialCustomer]
+        )->run();
         $this->customerAccountIndex->getInfoBlock()->openEditContactInfo();
         $this->customerAccountEdit->getAccountInfoForm()->fill($customer);
         $this->customerAccountEdit->getAccountInfoForm()->submit();
@@ -157,8 +143,6 @@ public function test(
      */
     public function tearDown()
     {
-        if ($this->cmsIndex->getLinksBlock()->isVisible()) {
-            $this->objectManager->create('Magento\Customer\Test\TestStep\LogoutCustomerOnFrontendStep')->run();
-        }
+        $this->objectManager->create('Magento\Customer\Test\TestStep\LogoutCustomerOnFrontendStep')->run();
     }
 }

dev/tests/functional/tests/app/Magento/Wishlist/Test/Constraint/AssertWishlistIsEmpty.php

@@ -25,6 +25,7 @@ class AssertWishlistIsEmpty extends AbstractConstraint
      */
     public function processAssert(CmsIndex $cmsIndex, WishlistIndex $wishlistIndex)
     {
+        $cmsIndex->getCmsPageBlock()->waitPageInit();
         $cmsIndex->getLinksBlock()->openLink("My Wish List");
         \PHPUnit_Framework_Assert::assertTrue(
             $wishlistIndex->getWishlistBlock()->isEmptyBlockVisible(),