Static test issues fixed

glo80326 · glo80326 · commit 3fdf706085da · 2021-12-02T09:53:32.000+05:30
diff --git a/app/code/Magento/Authorization/Model/UserContextInterface.php b/app/code/Magento/Authorization/Model/UserContextInterface.php
@@ -17,10 +17,10 @@ interface UserContextInterface
     /**#@+
      * User type
      */
-    const USER_TYPE_INTEGRATION = 1;
-    const USER_TYPE_ADMIN = 2;
-    const USER_TYPE_CUSTOMER = 3;
-    const USER_TYPE_GUEST = 4;
+    public const USER_TYPE_INTEGRATION = 1;
+    public const USER_TYPE_ADMIN = 2;
+    public const USER_TYPE_CUSTOMER = 3;
+    public const USER_TYPE_GUEST = 4;
     /**#@-*/
 
     /**
diff --git a/app/code/Magento/Backend/Model/Auth/Session.php b/app/code/Magento/Backend/Model/Auth/Session.php
@@ -33,7 +33,7 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
     /**
      * Admin session lifetime config path
      */
-    const XML_PATH_SESSION_LIFETIME = 'admin/security/session_lifetime';
+    public const XML_PATH_SESSION_LIFETIME = 'admin/security/session_lifetime';
 
     /**
      * @var boolean
diff --git a/app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php b/app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php
@@ -52,7 +52,7 @@
  */
 class Eav extends AbstractModifier
 {
-    const SORT_ORDER_MULTIPLIER = 10;
+    public const SORT_ORDER_MULTIPLIER = 10;
 
     /**
      * @var LocatorInterface
diff --git a/app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php b/app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php
@@ -36,7 +36,7 @@
  */
 class IndexBuilder
 {
-    const SECONDS_IN_DAY = 86400;
+    public const SECONDS_IN_DAY = 86400;
 
     /**
      * @var \Magento\Framework\EntityManager\MetadataPool
diff --git a/app/code/Magento/Customer/Api/AccountManagementInterface.php b/app/code/Magento/Customer/Api/AccountManagementInterface.php
@@ -19,10 +19,10 @@ interface AccountManagementInterface
     /**#@+
      * Constant for confirmation status
      */
-    const ACCOUNT_CONFIRMED = 'account_confirmed';
-    const ACCOUNT_CONFIRMATION_REQUIRED = 'account_confirmation_required';
-    const ACCOUNT_CONFIRMATION_NOT_REQUIRED = 'account_confirmation_not_required';
-    const MAX_PASSWORD_LENGTH = 256;
+    public const ACCOUNT_CONFIRMED = 'account_confirmed';
+    public const ACCOUNT_CONFIRMATION_REQUIRED = 'account_confirmation_required';
+    public const ACCOUNT_CONFIRMATION_NOT_REQUIRED = 'account_confirmation_not_required';
+    public const MAX_PASSWORD_LENGTH = 256;
     /**#@-*/
 
     /**
diff --git a/app/code/Magento/Downloadable/Model/Link.php b/app/code/Magento/Downloadable/Model/Link.php
@@ -19,36 +19,36 @@
  */
 class Link extends \Magento\Framework\Model\AbstractExtensibleModel implements ComponentInterface, LinkInterface
 {
-    const XML_PATH_LINKS_TITLE = 'catalog/downloadable/links_title';
+    public const XML_PATH_LINKS_TITLE = 'catalog/downloadable/links_title';
 
-    const XML_PATH_DEFAULT_DOWNLOADS_NUMBER = 'catalog/downloadable/downloads_number';
+    public const XML_PATH_DEFAULT_DOWNLOADS_NUMBER = 'catalog/downloadable/downloads_number';
 
-    const XML_PATH_TARGET_NEW_WINDOW = 'catalog/downloadable/links_target_new_window';
+    public const XML_PATH_TARGET_NEW_WINDOW = 'catalog/downloadable/links_target_new_window';
 
-    const XML_PATH_CONFIG_IS_SHAREABLE = 'catalog/downloadable/shareable';
+    public const XML_PATH_CONFIG_IS_SHAREABLE = 'catalog/downloadable/shareable';
 
-    const LINK_SHAREABLE_YES = 1;
+    public const LINK_SHAREABLE_YES = 1;
 
-    const LINK_SHAREABLE_NO = 0;
+    public const LINK_SHAREABLE_NO = 0;
 
-    const LINK_SHAREABLE_CONFIG = 2;
+    public const LINK_SHAREABLE_CONFIG = 2;
 
     /**#@+
      * Constants for field names
      */
-    const KEY_TITLE = 'title';
-    const KEY_SORT_ORDER = 'sort_order';
-    const KEY_IS_SHAREABLE = 'is_shareable';
-    const KEY_PRICE = 'price';
-    const KEY_NUMBER_OF_DOWNLOADS = 'number_of_downloads';
-    const KEY_LINK_TYPE = 'link_type';
-    const KEY_LINK_FILE = 'link_file';
-    const KEY_LINK_FILE_CONTENT = 'link_file_content';
-    const KEY_LINK_URL = 'link_url';
-    const KEY_SAMPLE_TYPE = 'sample_type';
-    const KEY_SAMPLE_FILE = 'sample_file';
-    const KEY_SAMPLE_FILE_CONTENT = 'sample_file_content';
-    const KEY_SAMPLE_URL = 'sample_url';
+    public const KEY_TITLE = 'title';
+    public const KEY_SORT_ORDER = 'sort_order';
+    public const KEY_IS_SHAREABLE = 'is_shareable';
+    public const KEY_PRICE = 'price';
+    public const KEY_NUMBER_OF_DOWNLOADS = 'number_of_downloads';
+    public const KEY_LINK_TYPE = 'link_type';
+    public const KEY_LINK_FILE = 'link_file';
+    public const KEY_LINK_FILE_CONTENT = 'link_file_content';
+    public const KEY_LINK_URL = 'link_url';
+    public const KEY_SAMPLE_TYPE = 'sample_type';
+    public const KEY_SAMPLE_FILE = 'sample_file';
+    public const KEY_SAMPLE_FILE_CONTENT = 'sample_file_content';
+    public const KEY_SAMPLE_URL = 'sample_url';
     /**#@-*/
 
     /**
diff --git a/app/code/Magento/Integration/Model/Config.php b/app/code/Magento/Integration/Model/Config.php
@@ -19,7 +19,7 @@
  */
 class Config
 {
-    const CACHE_ID = 'integration';
+    public const CACHE_ID = 'integration';
 
     /**
      * @var \Magento\Framework\App\Cache\Type\Config
diff --git a/app/code/Magento/Integration/Model/Integration.php b/app/code/Magento/Integration/Model/Integration.php
@@ -33,41 +33,41 @@ class Integration extends \Magento\Framework\Model\AbstractModel
     /**#@+
      * Integration Status values
      */
-    const STATUS_INACTIVE = 0;
+    public const STATUS_INACTIVE = 0;
 
-    const STATUS_ACTIVE = 1;
+    public const STATUS_ACTIVE = 1;
 
-    const STATUS_RECREATED = 2;
+    public const STATUS_RECREATED = 2;
 
     /**#@-*/
 
     /**#@+
      * Integration setup type
      */
-    const TYPE_MANUAL = 0;
+    public const TYPE_MANUAL = 0;
 
-    const TYPE_CONFIG = 1;
+    public const TYPE_CONFIG = 1;
 
     /**#@-*/
 
     /**#@+
      * Integration data key constants.
      */
-    const ID = 'integration_id';
+    public const ID = 'integration_id';
 
-    const NAME = 'name';
+    public const NAME = 'name';
 
-    const EMAIL = 'email';
+    public const EMAIL = 'email';
 
-    const ENDPOINT = 'endpoint';
+    public const ENDPOINT = 'endpoint';
 
-    const IDENTITY_LINK_URL = 'identity_link_url';
+    public const IDENTITY_LINK_URL = 'identity_link_url';
 
-    const SETUP_TYPE = 'setup_type';
+    public const SETUP_TYPE = 'setup_type';
 
-    const CONSUMER_ID = 'consumer_id';
+    public const CONSUMER_ID = 'consumer_id';
 
-    const STATUS = 'status';
+    public const STATUS = 'status';
 
     /**#@-*/
 
diff --git a/app/code/Magento/Integration/Model/IntegrationConfig.php b/app/code/Magento/Integration/Model/IntegrationConfig.php
@@ -21,7 +21,7 @@
  */
 class IntegrationConfig
 {
-    const CACHE_ID = 'integration-api';
+    public const CACHE_ID = 'integration-api';
 
     /**
      * @var \Magento\Framework\App\Cache\Type\Config
diff --git a/app/code/Magento/Msrp/Model/Config.php b/app/code/Magento/Msrp/Model/Config.php
@@ -18,10 +18,10 @@ class Config
     /**#@+
      * Minimum advertise price constants
      */
-    const XML_PATH_MSRP_ENABLED = 'sales/msrp/enabled';
-    const XML_PATH_MSRP_DISPLAY_ACTUAL_PRICE_TYPE = 'sales/msrp/display_price_type';
-    const XML_PATH_MSRP_EXPLANATION_MESSAGE = 'sales/msrp/explanation_message';
-    const XML_PATH_MSRP_EXPLANATION_MESSAGE_WHATS_THIS = 'sales/msrp/explanation_message_whats_this';
+    public const XML_PATH_MSRP_ENABLED = 'sales/msrp/enabled';
+    public const XML_PATH_MSRP_DISPLAY_ACTUAL_PRICE_TYPE = 'sales/msrp/display_price_type';
+    public const XML_PATH_MSRP_EXPLANATION_MESSAGE = 'sales/msrp/explanation_message';
+    public const XML_PATH_MSRP_EXPLANATION_MESSAGE_WHATS_THIS = 'sales/msrp/explanation_message_whats_this';
     /**#@-*/
 
     /**
diff --git a/app/code/Magento/OfflinePayments/Model/Purchaseorder.php b/app/code/Magento/OfflinePayments/Model/Purchaseorder.php
@@ -18,7 +18,7 @@
  */
 class Purchaseorder extends \Magento\Payment\Model\Method\AbstractMethod
 {
-    const PAYMENT_METHOD_PURCHASEORDER_CODE = 'purchaseorder';
+    public const PAYMENT_METHOD_PURCHASEORDER_CODE = 'purchaseorder';
 
     /**
      * @var string
diff --git a/app/code/Magento/PageCache/Model/Config.php b/app/code/Magento/PageCache/Model/Config.php
@@ -23,26 +23,26 @@ class Config
     /**
      * Cache types
      */
-    const BUILT_IN = 1;
+    public const BUILT_IN = 1;
 
-    const VARNISH = 2;
+    public const VARNISH = 2;
 
     /**
      * XML path to Varnish settings
      */
-    const XML_PAGECACHE_TTL = 'system/full_page_cache/ttl';
+    public const XML_PAGECACHE_TTL = 'system/full_page_cache/ttl';
 
-    const XML_PAGECACHE_TYPE = 'system/full_page_cache/caching_application';
+    public const XML_PAGECACHE_TYPE = 'system/full_page_cache/caching_application';
 
-    const XML_VARNISH_PAGECACHE_ACCESS_LIST = 'system/full_page_cache/varnish/access_list';
+    public const XML_VARNISH_PAGECACHE_ACCESS_LIST = 'system/full_page_cache/varnish/access_list';
 
-    const XML_VARNISH_PAGECACHE_BACKEND_PORT = 'system/full_page_cache/varnish/backend_port';
+    public const XML_VARNISH_PAGECACHE_BACKEND_PORT = 'system/full_page_cache/varnish/backend_port';
 
-    const XML_VARNISH_PAGECACHE_BACKEND_HOST = 'system/full_page_cache/varnish/backend_host';
+    public const XML_VARNISH_PAGECACHE_BACKEND_HOST = 'system/full_page_cache/varnish/backend_host';
 
-    const XML_VARNISH_PAGECACHE_GRACE_PERIOD = 'system/full_page_cache/varnish/grace_period';
+    public const XML_VARNISH_PAGECACHE_GRACE_PERIOD = 'system/full_page_cache/varnish/grace_period';
 
-    const XML_VARNISH_PAGECACHE_DESIGN_THEME_REGEX = 'design/theme/ua_regexp';
+    public const XML_VARNISH_PAGECACHE_DESIGN_THEME_REGEX = 'design/theme/ua_regexp';
 
     /**
      * @var \Magento\Framework\App\Config\ScopeConfigInterface
@@ -52,17 +52,17 @@ class Config
     /**
      * XML path to Varnish 6 config template path
      */
-    const VARNISH_6_CONFIGURATION_PATH = 'system/full_page_cache/varnish6/path';
+    public const VARNISH_6_CONFIGURATION_PATH = 'system/full_page_cache/varnish6/path';
 
     /**
      * XML path to Varnish 5 config template path
      */
-    const VARNISH_5_CONFIGURATION_PATH = 'system/full_page_cache/varnish5/path';
+    public const VARNISH_5_CONFIGURATION_PATH = 'system/full_page_cache/varnish5/path';
 
     /**
      * XML path to Varnish 4 config template path
      */
-    const VARNISH_4_CONFIGURATION_PATH = 'system/full_page_cache/varnish4/path';
+    public const VARNISH_4_CONFIGURATION_PATH = 'system/full_page_cache/varnish4/path';
 
     /**
      * @var \Magento\Framework\App\Cache\StateInterface $_cacheState
diff --git a/app/code/Magento/Payment/Model/Cart.php b/app/code/Magento/Payment/Model/Cart.php
@@ -22,13 +22,13 @@ class Cart
     /**#@+
      * Amounts
      */
-    const AMOUNT_TAX = 'tax';
+    public const AMOUNT_TAX = 'tax';
 
-    const AMOUNT_SHIPPING = 'shipping';
+    public const AMOUNT_SHIPPING = 'shipping';
 
-    const AMOUNT_DISCOUNT = 'discount';
+    public const AMOUNT_DISCOUNT = 'discount';
 
-    const AMOUNT_SUBTOTAL = 'subtotal';
+    public const AMOUNT_SUBTOTAL = 'subtotal';
     /**#@-*/
 
     /**
diff --git a/app/code/Magento/Payment/Model/Config.php b/app/code/Magento/Payment/Model/Config.php
@@ -19,7 +19,7 @@
  */
 class Config
 {
-    const YEARS_RANGE = 10;
+    public const YEARS_RANGE = 10;
 
     /**
      * @var array
diff --git a/app/code/Magento/Payment/Model/Method/AbstractMethod.php b/app/code/Magento/Payment/Model/Method/AbstractMethod.php
@@ -32,17 +32,17 @@ abstract class AbstractMethod extends \Magento\Framework\Model\AbstractExtensibl
     MethodInterface,
     PaymentMethodInterface
 {
-    const STATUS_UNKNOWN = 'UNKNOWN';
+    public const STATUS_UNKNOWN = 'UNKNOWN';
 
-    const STATUS_APPROVED = 'APPROVED';
+    public const STATUS_APPROVED = 'APPROVED';
 
-    const STATUS_ERROR = 'ERROR';
+    public const STATUS_ERROR = 'ERROR';
 
-    const STATUS_DECLINED = 'DECLINED';
+    public const STATUS_DECLINED = 'DECLINED';
 
-    const STATUS_VOID = 'VOID';
+    public const STATUS_VOID = 'VOID';
 
-    const STATUS_SUCCESS = 'SUCCESS';
+    public const STATUS_SUCCESS = 'SUCCESS';
 
     /**
      * @var string
diff --git a/app/code/Magento/Persistent/Model/Session.php b/app/code/Magento/Persistent/Model/Session.php
@@ -20,12 +20,12 @@ class Session extends \Magento\Framework\Model\AbstractModel
     /**
      * Persistent cookie key length
      */
-    const KEY_LENGTH = 50;
+    public const KEY_LENGTH = 50;
 
     /**
      * Persistent cookie name
      */
-    const COOKIE_NAME = 'persistent_shopping_cart';
+    public const COOKIE_NAME = 'persistent_shopping_cart';
 
     /**
      * @var string[]
diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php
@@ -18,7 +18,7 @@
  */
 abstract class AbstractCarrier extends \Magento\Framework\DataObject implements AbstractCarrierInterface
 {
-    const DEBUG_KEYS_MASK = '****';
+    public const DEBUG_KEYS_MASK = '****';
 
     /**
      * @var string
@@ -50,19 +50,19 @@ abstract class AbstractCarrier extends \Magento\Framework\DataObject implements
      */
     protected $_customizableContainerTypes = [];
 
-    const USA_COUNTRY_ID = 'US';
+    public const USA_COUNTRY_ID = 'US';
 
-    const CANADA_COUNTRY_ID = 'CA';
+    public const CANADA_COUNTRY_ID = 'CA';
 
-    const MEXICO_COUNTRY_ID = 'MX';
+    public const MEXICO_COUNTRY_ID = 'MX';
 
-    const HANDLING_TYPE_PERCENT = 'P';
+    public const HANDLING_TYPE_PERCENT = 'P';
 
-    const HANDLING_TYPE_FIXED = 'F';
+    public const HANDLING_TYPE_FIXED = 'F';
 
-    const HANDLING_ACTION_PERPACKAGE = 'P';
+    public const HANDLING_ACTION_PERPACKAGE = 'P';
 
-    const HANDLING_ACTION_PERORDER = 'O';
+    public const HANDLING_ACTION_PERORDER = 'O';
 
     /**
      * @var array
diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php
@@ -22,13 +22,13 @@
  */
 abstract class AbstractCarrierOnline extends AbstractCarrier
 {
-    const USA_COUNTRY_ID = 'US';
+    public const USA_COUNTRY_ID = 'US';
 
-    const PUERTORICO_COUNTRY_ID = 'PR';
+    public const PUERTORICO_COUNTRY_ID = 'PR';
 
-    const GUAM_COUNTRY_ID = 'GU';
+    public const GUAM_COUNTRY_ID = 'GU';
 
-    const GUAM_REGION_CODE = 'GU';
+    public const GUAM_REGION_CODE = 'GU';
 
     /**
      * @var array
diff --git a/app/code/Magento/User/Model/User.php b/app/code/Magento/User/Model/User.php
diff --git a/dev/tests/api-functional/_files/Magento/TestModuleDefaultHydrator/Api/Data/ExtensionAttributeInterface.php b/dev/tests/api-functional/_files/Magento/TestModuleDefaultHydrator/Api/Data/ExtensionAttributeInterface.php
diff --git a/lib/internal/Magento/Framework/Pricing/Render.php b/lib/internal/Magento/Framework/Pricing/Render.php

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@`
`52`	`52`	`*/`
`53`	`53`	`class Eav extends AbstractModifier`
`54`	`54`	`{`
`55`		`- const SORT_ORDER_MULTIPLIER = 10;`
	`55`	`+ public const SORT_ORDER_MULTIPLIER = 10;`
`56`	`56`
`57`	`57`	`/**`
`58`	`58`	`* @var LocatorInterface`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`	`*/`
`37`	`37`	`class IndexBuilder`
`38`	`38`	`{`
`39`		`- const SECONDS_IN_DAY = 86400;`
	`39`	`+ public const SECONDS_IN_DAY = 86400;`
`40`	`40`
`41`	`41`	`/**`
`42`	`42`	`* @var \Magento\Framework\EntityManager\MetadataPool`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*/`
`20`	`20`	`class Config`
`21`	`21`	`{`
`22`		`- const CACHE_ID = 'integration';`
	`22`	`+ public const CACHE_ID = 'integration';`
`23`	`23`
`24`	`24`	`/**`
`25`	`25`	`* @var \Magento\Framework\App\Cache\Type\Config`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`*/`
`22`	`22`	`class IntegrationConfig`
`23`	`23`	`{`
`24`		`- const CACHE_ID = 'integration-api';`
	`24`	`+ public const CACHE_ID = 'integration-api';`
`25`	`25`
`26`	`26`	`/**`
`27`	`27`	`* @var \Magento\Framework\App\Cache\Type\Config`