Code Review fix

glo80326 · glo80326 · commit 4e43c1aaf96f · 2021-12-01T22:22:01.000+05:30
diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php
@@ -428,7 +428,8 @@ protected function _setCachedQuotes($requestParams, $response)
      */
     protected function _prepareServiceName($name)
     {
-        $name = htmlspecialchars_decode((string)$name);
+        // phpcs:disable Magento2.Functions.DiscouragedFunction
+        $name = html_entity_decode((string)$name);
         $name = strip_tags(preg_replace('#&\w+;#', '', $name));
 
         return trim($name);

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,8 @@ protected function _setCachedQuotes($requestParams, $response)`
`428`	`428`	`*/`
`429`	`429`	`protected function _prepareServiceName($name)`
`430`	`430`	`{`
`431`		`- $name = htmlspecialchars_decode((string)$name);`
	`431`	`+ // phpcs:disable Magento2.Functions.DiscouragedFunction`
	`432`	`+ $name = html_entity_decode((string)$name);`
`432`	`433`	`$name = strip_tags(preg_replace('#&\w+;#', '', $name));`
`433`	`434`
`434`	`435`	`return trim($name);`