ACPT-1408: Investigate 1m call on 1k rules

Author: vzabaznov

app/code/Magento/Quote/Model/Quote/Address.php

@@ -86,7 +86,6 @@
  * @method float getDiscountAmount()
  * @method Address setDiscountAmount(float $value)
  * @method float getBaseDiscountAmount()
- * @method Address setBaseDiscountAmount(float $value)
  * @method float getGrandTotal()
  * @method Address setGrandTotal(float $value)
  * @method float getBaseGrandTotal()
@@ -142,6 +141,8 @@ class Address extends AbstractAddress implements
 
     private const CACHED_ITEMS_ALL = 'cached_items_all';
 
+    private const BASE_DISCOUNT_AMOUNT = 'base_discount_amount';
+
     /**
      * Prefix of model events
      *
@@ -1796,4 +1797,15 @@ protected function getCustomAttributesCodes()
     {
         return array_keys($this->attributeList->getAttributes());
     }
+
+    /**
+     * @param float $value
+     * @return $this
+     */
+    public function setBaseDiscountAmount(float $value)
+    {
+        $this->_data[self::BASE_DISCOUNT_AMOUNT] = $value;
+
+        return $this;
+    }
 }

app/code/Magento/SalesRule/Model/Quote/Discount.php

@@ -199,17 +199,9 @@ public function collect(
                     unset($itemsToApplyRules[$key]);
                 }
 
-                //@TODO write actual implementation//
-//                $address->setDiscountAmount($total->getDiscountAmount());
-//                $address->setBaseDiscountAmount($total->getBaseDiscountAmount());
                 $totalDiscount += $item->getBaseDiscountAmount();
-//                $address->setBaseDiscountAmount($totalDiscount);
-//                $address->setSubtotalWithDiscount($total->getSubtotal() + $total->getDiscountAmount());
-
-//                $this->calculator->initTotal($item, $rule, $address);
             }
             $address->setBaseDiscountAmount($totalDiscount);
-//            $this->calculator->initTotals($items, $address);
         }
         $this->calculator->initTotals($items, $address);
         foreach ($items as $item) {

dev/tests/integration/testsuite/Magento/SalesRule/Model/Rule/Action/Discount/CartFixedTest.php

@@ -305,7 +305,7 @@ private function createProduct(float $price): ProductInterface
 
         return $productRepository->save($product);
     }
-//
+
     /**
      * Gets order entity by increment id.
      *