ACPT-1408: Investigate 1m call on 1k rules

Author: vzabaznov

app/code/Magento/SalesRule/Helper/CartFixedDiscount.php

@@ -123,7 +123,7 @@ public function getDiscountAmount(
      * @param float $qty
      * @param float $baseItemPrice
      * @param float $baseItemDiscountAmount
-     * @param float $baseRuleTotalsDiscount
+     * @param float $baseRuleTotalsWithDiscount
      * @param string $discountType
      * @return float
      */
@@ -138,6 +138,7 @@ public function getDiscountedAmountProportionally(
         $baseItemPriceTotal = $baseItemPrice * $qty - $baseItemDiscountAmount;
         $ratio = $baseRuleTotalsDiscount != 0 ? $baseItemPriceTotal / $baseRuleTotalsDiscount : 0;
         $discountAmount = $this->deltaPriceRound->round($ruleDiscount * $ratio, $discountType);
+
         return $discountAmount;
     }
 

app/code/Magento/SalesRule/Model/Quote/Discount.php

@@ -178,6 +178,8 @@ public function collect(
         $items = $this->calculator->sortItemsByPriority($items, $address);
         $itemsToApplyRules = $items;
         $rules = $this->calculator->getRules($address);
+        $totalDiscount = 0;
+        $address->setBaseDiscountAmount(0);
         /** @var Rule $rule */
         foreach ($rules as $rule) {
             /** @var Item $item */
@@ -190,12 +192,23 @@ public function collect(
                 }
                 $eventArgs['item'] = $item;
                 $this->eventManager->dispatch('sales_quote_address_discount_item', $eventArgs);
+
                 $this->calculator->process($item, $rule);
                 $appliedRuleIds = $item->getAppliedRuleIds() ? explode(',', $item->getAppliedRuleIds()) : [];
                 if ($rule->getStopRulesProcessing() && in_array($rule->getId(), $appliedRuleIds)) {
                     unset($itemsToApplyRules[$key]);
                 }
+
+                //@TODO write actual implementation//
+//                $address->setDiscountAmount($total->getDiscountAmount());
+//                $address->setBaseDiscountAmount($total->getBaseDiscountAmount());
+                $totalDiscount += $item->getBaseDiscountAmount();
+//                $address->setBaseDiscountAmount($totalDiscount);
+//                $address->setSubtotalWithDiscount($total->getSubtotal() + $total->getDiscountAmount());
+
+//                $this->calculator->initTotal($item, $rule, $address);
             }
+            $address->setBaseDiscountAmount($totalDiscount);
 //            $this->calculator->initTotals($items, $address);
         }
         $this->calculator->initTotals($items, $address);

app/code/Magento/SalesRule/Model/Rule/Action/Discount/CartFixed.php

@@ -134,7 +134,7 @@ public function calculate($rule, $item, $qty)
                         $qty,
                         $baseItemPrice,
                         $baseItemDiscountAmount,
-                        $baseRuleTotals - $baseRuleTotalsDiscount,
+                        $baseRuleTotals - $address->getBaseDiscountAmount(),
                         $discountType
                     );
             }