Added Unit Test for Severity Block. Use FQCN. Added strict type hints

Author: DavidLambauer

app/code/Magento/AdminNotification/Block/Grid/Renderer/Severity.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * Adminhtml AdminNotification Severity Renderer
  *
@@ -7,9 +9,13 @@
  */
 namespace Magento\AdminNotification\Block\Grid\Renderer;
 
+use Magento\AdminNotification\Model\Inbox;
+use Magento\Backend\Block\Context;
+use Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer;
+use Magento\Framework\DataObject;
 use Magento\Framework\Notification\MessageInterface;
 
-class Severity extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer
+class Severity extends AbstractRenderer
 {
     /**
      * @var \Magento\AdminNotification\Model\Inbox
@@ -21,11 +27,8 @@ class Severity extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Abstra
      * @param \Magento\AdminNotification\Model\Inbox $notice
      * @param array $data
      */
-    public function __construct(
-        \Magento\Backend\Block\Context $context,
-        \Magento\AdminNotification\Model\Inbox $notice,
-        array $data = []
-    ) {
+    public function __construct(Context $context, Inbox $notice, array $data = [])
+    {
         parent::__construct($context, $data);
         $this->_notice = $notice;
     }
@@ -36,12 +39,14 @@ public function __construct(
      * @param   \Magento\Framework\DataObject $row
      * @return  string
      */
-    public function render(\Magento\Framework\DataObject $row)
+    public function render(DataObject $row) : string
     {
         $class = '';
         $value = '';
 
-        switch ($row->getData($this->getColumn()->getIndex())) {
+        $column = $this->getColumn();
+        $index  = $column->getData('index');
+        switch ($row->getData($index)) {
             case MessageInterface::SEVERITY_CRITICAL:
                 $class = 'critical';
                 $value = $this->_notice->getSeverities(MessageInterface::SEVERITY_CRITICAL);
@@ -59,6 +64,7 @@ public function render(\Magento\Framework\DataObject $row)
                 $value = $this->_notice->getSeverities(MessageInterface::SEVERITY_NOTICE);
                 break;
         }
+
         return '<span class="grid-severity-' . $class . '"><span>' . $value . '</span></span>';
     }
 }

app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/SeverityTest.php

@@ -0,0 +1,87 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+/**
+ * Test class for \Magento\AdminNotification\Block\Grid\Renderer\Actions
+ */
+namespace Magento\AdminNotification\Test\Unit\Block\Grid\Renderer;
+
+use Magento\AdminNotification\Block\Grid\Renderer\Severity;
+use Magento\AdminNotification\Model\Inbox;
+use Magento\Backend\Block\Context;
+use Magento\Backend\Block\Widget\Grid\Column;
+use Magento\Framework\DataObject;
+use Magento\Framework\Escaper;
+use PHPUnit\Framework\TestCase;
+
+class SeverityTest extends TestCase
+{
+    /**
+     * System under Test
+     *
+     * @var Severity
+     */
+    private $sut;
+
+    protected function setUp() : void
+    {
+        parent::setUp();
+
+        /** @var Inbox |\PHPUnit_Framework_MockObject_MockObject $inboxMock */
+        $inboxMock = $this->getMockBuilder(Inbox::class)->disableOriginalConstructor()->getMock();
+
+        /** @var Context | \PHPUnit_Framework_MockObject_MockObject $contextMock */
+        $contextMock = $this->getMockBuilder(Context::class)->disableOriginalConstructor()->getMock();
+
+        $this->sut = new Severity($contextMock, $inboxMock);
+    }
+
+    public function test_should_render_severity() : void
+    {
+        /** @var Column | \PHPUnit_Framework_MockObject_MockObject $columnMock */
+        $columnMock = $this->getMockBuilder(Column::class)->disableOriginalConstructor()->getMock();
+        $columnMock->expects($this->exactly(5))->method('getData')->with($this->equalTo('index'))->willReturn('a magic index');
+        $this->sut->setColumn($columnMock);
+        $dataObject = new DataObject();
+
+        // Test critical severity
+        $dataObject->setData('a magic index', 1);
+        $actual = $this->sut->render($dataObject);
+        $expected = '<span class="grid-severity-critical"><span></span></span>';
+
+        $this->assertEquals($actual, $expected);
+
+        // Test major severity
+        $dataObject->setData('a magic index', 2);
+        $actual = $this->sut->render($dataObject);
+        $expected = '<span class="grid-severity-major"><span></span></span>';
+
+        $this->assertEquals($actual, $expected);
+
+        // Test minor severity
+        $dataObject->setData('a magic index', 3);
+        $actual = $this->sut->render($dataObject);
+        $expected = '<span class="grid-severity-minor"><span></span></span>';
+
+        $this->assertEquals($actual, $expected);
+
+        // Test notice severity
+        $dataObject->setData('a magic index', 4);
+        $actual = $this->sut->render($dataObject);
+        $expected = '<span class="grid-severity-notice"><span></span></span>';
+
+        $this->assertEquals($actual, $expected);
+
+        // Test default severity
+        $dataObject->setData('a magic index', 5);
+        $actual = $this->sut->render($dataObject);
+        $expected = '<span class="grid-severity-"><span></span></span>';
+
+        $this->assertEquals($actual, $expected);
+    }
+}