Added Unit Test for Notice Block. Added strict type hint. Removed

Code-Smell

Author: DavidLambauer

app/code/Magento/AdminNotification/Block/Grid/Renderer/Notice.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * Adminhtml AdminNotification Severity Renderer
  *
@@ -7,19 +9,22 @@
  */
 namespace Magento\AdminNotification\Block\Grid\Renderer;
 
-class Notice extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer
+use Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer;
+use Magento\Framework\DataObject;
+
+class Notice extends AbstractRenderer
 {
     /**
      * Renders grid column
      *
      * @param   \Magento\Framework\DataObject $row
      * @return  string
      */
-    public function render(\Magento\Framework\DataObject $row)
+    public function render(DataObject $row) : string
     {
         return '<span class="grid-row-title">' .
-            $this->escapeHtml($row->getTitle()) .
+            $this->escapeHtml($row->getData('title')) .
             '</span>' .
-            ($row->getDescription() ? '<br />' . $this->escapeHtml($row->getDescription()) : '');
+            ($row->getData('description') ? '<br />' . $this->escapeHtml($row->getData('description')) : '');
     }
 }

app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/NoticeTest.php

@@ -0,0 +1,56 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+/**
+ * Test class for \Magento\AdminNotification\Block\Grid\Renderer\Actions
+ */
+namespace Magento\AdminNotification\Test\Unit\Block\Grid\Renderer;
+
+use Magento\AdminNotification\Block\Grid\Renderer\Notice;
+use Magento\Framework\DataObject;
+use Magento\Framework\Escaper;
+use Magento\Backend\Block\Context;
+use PHPUnit\Framework\TestCase;
+
+class NoticeTest extends TestCase
+{
+    /**
+     * System under Test
+     *
+     * @var Notice
+     */
+    private $sut;
+
+    protected function setUp() : void
+    {
+        parent::setUp();
+
+        /** @var Escaper | \PHPUnit_Framework_MockObject_MockObject $escaperMock */
+        $escaperMock = $this->getMockBuilder(Escaper::class)->disableOriginalConstructor()->getMock();
+        $escaperMock->expects($this->exactly(2))->method('escapeHtml')->willReturn('<div>Some random html</div>');
+
+        /** @var Context | \PHPUnit_Framework_MockObject_MockObject $contextMock */
+        $contextMock = $this->getMockBuilder(Context::class)->disableOriginalConstructor()->getMock();
+        $contextMock->expects($this->once())->method('getEscaper')->willReturn($escaperMock);
+
+        $this->sut = new Notice($contextMock);
+
+    }
+
+    public function test_should_render_notice() : void
+    {
+        $dataObject = new DataObject();
+        $dataObject->setData('title', 'A great Title');
+        $dataObject->setData('description', 'Handy description right here');
+
+        $actual = $this->sut->render($dataObject);
+        $expected = '<span class="grid-row-title"><div>Some random html</div></span><br /><div>Some random html</div>';
+
+        $this->assertEquals($actual, $expected);
+    }
+}