MAGETWO-95945: Add a code mess rule for improper session and cookies usages

Author: Oleksandr Gorkun

app/code/Magento/Customer/Model/FileProcessor.php

@@ -9,7 +9,6 @@
 
 /**
  * Class FileProcessor
- * @package Magento\Customer\Model
  */
 class FileProcessor
 {

dev/tests/static/framework/Magento/CodeMessDetector/Rule/Design/CookieAndSessionMisuse.php

@@ -74,25 +74,23 @@ private function isUiDocument(\ReflectionClass $class): bool
      */
     private function isControllerPlugin(\ReflectionClass $class): bool
     {
-        try {
-            foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
-                if (preg_match('/^(after|around|before).+/i', $method->getName())) {
-                    try {
-                        $argument = $method->getParameters()[0]->getClass();
-                    } catch (\ReflectionException $exception) {
-                        //Non-existing class (autogenerated perhaps)
-                        continue;
-                    }
-                    $isAction = $argument->isSubclassOf(\Magento\Framework\App\ActionInterface::class)
-                        || $argument->getName() === \Magento\Framework\App\ActionInterface::class;
-                    if ($isAction) {
-                        return true;
-                    }
+        foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
+            if (preg_match('/^(after|around|before).+/i', $method->getName())) {
+                try {
+                    $argument = $method->getParameters()[0]->getClass();
+                } catch (\ReflectionException $exception) {
+                    //Non-existing class (autogenerated perhaps)
+                    continue;
+                }
+                $isAction = $argument->isSubclassOf(\Magento\Framework\App\ActionInterface::class)
+                    || $argument->getName() === \Magento\Framework\App\ActionInterface::class;
+                if ($isAction) {
+                    return true;
                 }
             }
-        } catch (\Throwable $exception) {
-            return false;
         }
+
+        return false;
     }
 
     /**
@@ -103,25 +101,23 @@ private function isControllerPlugin(\ReflectionClass $class): bool
      */
     private function isBlockPlugin(\ReflectionClass $class): bool
     {
-        try {
-            foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
-                if (preg_match('/^(after|around|before).+/i', $method->getName())) {
-                    try {
-                        $argument = $method->getParameters()[0]->getClass();
-                    } catch (\ReflectionException $exception) {
-                        //Non-existing class (autogenerated perhaps)
-                        continue;
-                    }
-                    $isBlock = $argument->isSubclassOf(\Magento\Framework\View\Element\BlockInterface::class)
-                        || $argument->getName() === \Magento\Framework\View\Element\BlockInterface::class;
-                    if ($isBlock) {
-                        return true;
-                    }
+        foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
+            if (preg_match('/^(after|around|before).+/i', $method->getName())) {
+                try {
+                    $argument = $method->getParameters()[0]->getClass();
+                } catch (\ReflectionException $exception) {
+                    //Non-existing class (autogenerated perhaps)
+                    continue;
+                }
+                $isBlock = $argument->isSubclassOf(\Magento\Framework\View\Element\BlockInterface::class)
+                    || $argument->getName() === \Magento\Framework\View\Element\BlockInterface::class;
+                if ($isBlock) {
+                    return true;
                 }
             }
-        } catch (\Throwable $exception) {
-            return false;
         }
+
+        return false;
     }
 
     /**