MAGETWO-95945: Add a code mess rule for improper session and cookies usages

Author: Oleksandr Gorkun

dev/tests/static/framework/Magento/CodeMessDetector/Rule/Design/CookieAndSessionMisuse.php

@@ -77,7 +77,12 @@ private function isControllerPlugin(\ReflectionClass $class): bool
         try {
             foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
                 if (preg_match('/^(after|around|before).+/i', $method->getName())) {
-                    $argument = $method->getParameters()[0]->getClass();
+                    try {
+                        $argument = $method->getParameters()[0]->getClass();
+                    } catch (\ReflectionException $exception) {
+                        //Non-existing class (autogenerated perhaps)
+                        continue;
+                    }
                     $isAction = $argument->isSubclassOf(\Magento\Framework\App\ActionInterface::class)
                         || $argument->getName() === \Magento\Framework\App\ActionInterface::class;
                     if ($isAction) {
@@ -101,7 +106,12 @@ private function isBlockPlugin(\ReflectionClass $class): bool
         try {
             foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
                 if (preg_match('/^(after|around|before).+/i', $method->getName())) {
-                    $argument = $method->getParameters()[0]->getClass();
+                    try {
+                        $argument = $method->getParameters()[0]->getClass();
+                    } catch (\ReflectionException $exception) {
+                        //Non-existing class (autogenerated perhaps)
+                        continue;
+                    }
                     $isBlock = $argument->isSubclassOf(\Magento\Framework\View\Element\BlockInterface::class)
                         || $argument->getName() === \Magento\Framework\View\Element\BlockInterface::class;
                     if ($isBlock) {
@@ -125,14 +135,19 @@ private function doesUseRestrictedClasses(\ReflectionClass $class): bool
         $constructor = $class->getConstructor();
         if ($constructor) {
             foreach ($constructor->getParameters() as $argument) {
-                if ($class = $argument->getClass()) {
-                    if ($class->isSubclassOf(\Magento\Framework\Session\SessionManagerInterface::class)
-                        || $class->getName() === \Magento\Framework\Session\SessionManagerInterface::class
-                        || $class->isSubclassOf(\Magento\Framework\Stdlib\Cookie\CookieReaderInterface::class)
-                        || $class->getName() === \Magento\Framework\Stdlib\Cookie\CookieReaderInterface::class
-                    ) {
-                        return true;
+                try {
+                    if ($class = $argument->getClass()) {
+                        if ($class->isSubclassOf(\Magento\Framework\Session\SessionManagerInterface::class)
+                            || $class->getName() === \Magento\Framework\Session\SessionManagerInterface::class
+                            || $class->isSubclassOf(\Magento\Framework\Stdlib\Cookie\CookieReaderInterface::class)
+                            || $class->getName() === \Magento\Framework\Stdlib\Cookie\CookieReaderInterface::class
+                        ) {
+                            return true;
+                        }
                     }
+                } catch (\ReflectionException $exception) {
+                    //Failed to load the argument's class information
+                    continue;
                 }
             }
         }