Fix CS

DavidLambauer · DavidLambauer · commit 3188cac632b7 · 2019-08-11T17:43:59.000+02:00
diff --git a/app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/ActionsTest.php b/app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/ActionsTest.php
@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Copyright © Magento, Inc. All rights reserved.
@@ -9,6 +9,7 @@
 /**
  * Test class for \Magento\AdminNotification\Block\Grid\Renderer\Actions
  */
+
 namespace Magento\AdminNotification\Test\Unit\Block\Grid\Renderer;
 
 use Magento\AdminNotification\Block\Grid\Renderer\Actions;
@@ -23,7 +24,6 @@ class ActionsTest extends TestCase
 {
     /**
      * System under Test
-     *
      * @var Actions
      */
     private $sut;
@@ -50,20 +50,23 @@ protected function setUp() : void
         $urlHelperMock->expects($this->once())->method('getEncodedUrl')->willReturn('http://magento.com');
 
         $this->sut = new Actions($contextMock, $urlHelperMock);
-
     }
 
-    public function test_should_render_message_when_urlIsGiven() : void
+    public function testShouldRenderMessageWhenUrlIsGiven() : void
     {
         $dataObject = new DataObject();
         $dataObject->setdata('url', 'https://magento.com');
         $dataObject->setdata('is_read', true);
         $dataObject->setdata('id', 1);
 
-        $actual = $this->sut->render($dataObject);
+        $actual   = $this->sut->render($dataObject);
+
+        // Ignoring Code Style at this point due to the long HEREDOC
+        // phpcs:disable
         $expected = <<<HTML
 <a class="action-details" target="_blank" href="https://magento.com">Read Details</a><a class="action-delete" href="http://magento.com" onClick="deleteConfirm('Are you sure?', this.href); return false;">Remove</a>
 HTML;
+        // phpcs:enable
 
         $this->assertEquals($actual, $expected);
     }
diff --git a/app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/NoticeTest.php b/app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/NoticeTest.php
@@ -39,10 +39,9 @@ protected function setUp() : void
         $contextMock->expects($this->once())->method('getEscaper')->willReturn($escaperMock);
 
         $this->sut = new Notice($contextMock);
-
     }
 
-    public function test_should_render_notice() : void
+    public function testShouldRenderNotice() : void
     {
         $dataObject = new DataObject();
         $dataObject->setData('title', 'A great Title');
diff --git a/app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/SeverityTest.php b/app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/SeverityTest.php
@@ -41,44 +41,44 @@ protected function setUp() : void
         $this->sut = new Severity($contextMock, $inboxMock);
     }
 
-    public function test_should_render_severity() : void
+    public function testShouldRenderSeverity() : void
     {
         /** @var Column | \PHPUnit_Framework_MockObject_MockObject $columnMock */
         $columnMock = $this->getMockBuilder(Column::class)->disableOriginalConstructor()->getMock();
-        $columnMock->expects($this->exactly(5))->method('getData')->with($this->equalTo('index'))->willReturn('a magic index');
+        $columnMock->expects($this->exactly(5))->method('getData')->with($this->equalTo('index'))->willReturn('index');
         $this->sut->setColumn($columnMock);
         $dataObject = new DataObject();
 
         // Test critical severity
-        $dataObject->setData('a magic index', 1);
+        $dataObject->setData('index', 1);
         $actual = $this->sut->render($dataObject);
         $expected = '<span class="grid-severity-critical"><span></span></span>';
 
         $this->assertEquals($actual, $expected);
 
         // Test major severity
-        $dataObject->setData('a magic index', 2);
+        $dataObject->setData('index', 2);
         $actual = $this->sut->render($dataObject);
         $expected = '<span class="grid-severity-major"><span></span></span>';
 
         $this->assertEquals($actual, $expected);
 
         // Test minor severity
-        $dataObject->setData('a magic index', 3);
+        $dataObject->setData('index', 3);
         $actual = $this->sut->render($dataObject);
         $expected = '<span class="grid-severity-minor"><span></span></span>';
 
         $this->assertEquals($actual, $expected);
 
         // Test notice severity
-        $dataObject->setData('a magic index', 4);
+        $dataObject->setData('index', 4);
         $actual = $this->sut->render($dataObject);
         $expected = '<span class="grid-severity-notice"><span></span></span>';
 
         $this->assertEquals($actual, $expected);
 
         // Test default severity
-        $dataObject->setData('a magic index', 5);
+        $dataObject->setData('index', 5);
         $actual = $this->sut->render($dataObject);
         $expected = '<span class="grid-severity-"><span></span></span>';
 

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,9 @@ protected function setUp() : void`
`39`	`39`	`$contextMock->expects($this->once())->method('getEscaper')->willReturn($escaperMock);`
`40`	`40`
`41`	`41`	`$this->sut = new Notice($contextMock);`
`42`		`-`
`43`	`42`	`}`
`44`	`43`
`45`		`- public function test_should_render_notice() : void`
	`44`	`+ public function testShouldRenderNotice() : void`
`46`	`45`	`{`
`47`	`46`	`$dataObject = new DataObject();`
`48`	`47`	`$dataObject->setData('title', 'A great Title');`