fixes after a code review

Author: silinmykola

app/code/Magento/Catalog/Model/Product/Option/Type/Date.php

@@ -356,7 +356,7 @@ public function getYearStart()
      */
     public function getYearEnd()
     {
-        $_range = $this->getConfigData('year_range')
+        $_range = $this->getConfigData('year_range') !== null
             ? explode(',', $this->getConfigData('year_range')) : [];
         if (isset($_range[1]) && !empty($_range[1])) {
             return $_range[1];

app/code/Magento/Catalog/Ui/DataProvider/CatalogEavValidationRules.php

@@ -38,13 +38,11 @@ public function build(ProductAttributeInterface $attribute, array $data)
 
         foreach ($validationClasses as $class) {
             if (preg_match('/^maximum-length-(\d+)$/', $class, $matches)) {
-                // phpcs:ignore Magento2.Performance.ForeachArrayMerge
-                $rules = array_merge($rules, ['max_text_length' => $matches[1]]);
+                $rules['max_text_length'] = $matches[1];
                 continue;
             }
             if (preg_match('/^minimum-length-(\d+)$/', $class, $matches)) {
-                // phpcs:ignore Magento2.Performance.ForeachArrayMerge
-                $rules = array_merge($rules, ['min_text_length' => $matches[1]]);
+                $rules['min_text_length'] = $matches[1];
                 continue;
             }
 

app/code/Magento/Tax/Model/Calculation/RateRepository.php

@@ -103,8 +103,7 @@ public function __construct(
         $this->resourceModel = $rateResource;
         $this->joinProcessor = $joinProcessor;
         $this->collectionProcessor = $collectionProcessor ?? \Magento\Framework\App\ObjectManager::getInstance()->get(
-        // phpstan:ignore "Class Magento\Tax\Model\Api\SearchCriteria\TaxRateCollectionProcessor not found."
-            \Magento\Tax\Model\Api\SearchCriteria\TaxRateCollectionProcessor::class
+            'Magento\Tax\Model\Api\SearchCriteria\TaxRateCollectionProcessor'
         );
     }
 
@@ -273,7 +272,9 @@ private function validate(\Magento\Tax\Api\Data\TaxRateInterface $taxRate)
             );
         }
 
-        if (!\Zend_Validate::is(trim($taxRate->getCode() ?? ''), 'NotEmpty')) {
+        if ($taxRate->getCode() !== null
+            || !\Zend_Validate::is(trim($taxRate->getCode()), 'NotEmpty')
+        ) {
             $exception->addError(__('"%fieldName" is required. Enter and try again.', ['fieldName' => 'code']));
         }
 
@@ -296,8 +297,12 @@ private function validate(\Magento\Tax\Api\Data\TaxRateInterface $taxRate)
                 $exception->addError(__('Range To should be equal or greater than Range From.'));
             }
         } else {
-            if (!\Zend_Validate::is(trim($taxRate->getTaxPostcode() ?? ''), 'NotEmpty')) {
-                $exception->addError(__('"%fieldName" is required. Enter and try again.', ['fieldName' => 'postcode']));
+            if ($taxRate->getTaxPostcode() !== null
+                || !\Zend_Validate::is(trim($taxRate->getTaxPostcode()), 'NotEmpty')
+            ) {
+                $exception->addError(
+                    __('"%fieldName" is required. Enter and try again.', ['fieldName' => 'postcode'])
+                );
             }
         }
 

app/code/Magento/Tax/Model/Calculation/Rule/Validator.php

@@ -73,7 +73,7 @@ public function isValid($value)
         }
 
         // Code is required
-        if (!\Zend_Validate::is(trim($value->getCode() ?? ''), 'NotEmpty')) {
+        if ($value->getCode() !== null || !\Zend_Validate::is(trim($value->getCode()), 'NotEmpty')) {
             $this->addErrorMessage(
                 $messages,
                 '"%fieldName" is required. Enter and try again.',

setup/src/Magento/Setup/Test/Unit/Module/Setup/SetupCacheTest.php

@@ -60,7 +60,7 @@ public function testGetNonexistent($field)
     public function getNonexistentDataProvider()
     {
         return [
-            [''],
+            [null],
             ['field'],
         ];
     }