Skip to content

Commit d9ffd49

Browse files
author
silinmykola
committed
fixes for Static Tests
1 parent 013fa70 commit d9ffd49

File tree

2 files changed

+36
-36
lines changed
  • app/code/Magento

2 files changed

+36
-36
lines changed

app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,31 @@ class Option extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
5353

5454
public const COLUMN_ROW_SORT = '_custom_option_row_sort';
5555

56+
/**
57+
* Error codes
58+
*/
59+
public const ERROR_INVALID_STORE = 'optionInvalidStore';
60+
61+
public const ERROR_INVALID_TYPE = 'optionInvalidType';
62+
63+
public const ERROR_EMPTY_TITLE = 'optionEmptyTitle';
64+
65+
public const ERROR_INVALID_PRICE = 'optionInvalidPrice';
66+
67+
public const ERROR_INVALID_MAX_CHARACTERS = 'optionInvalidMaxCharacters';
68+
69+
public const ERROR_INVALID_SORT_ORDER = 'optionInvalidSortOrder';
70+
71+
public const ERROR_INVALID_ROW_PRICE = 'optionInvalidRowPrice';
72+
73+
public const ERROR_INVALID_ROW_SORT = 'optionInvalidRowSort';
74+
75+
public const ERROR_AMBIGUOUS_NEW_NAMES = 'optionAmbiguousNewNames';
76+
77+
public const ERROR_AMBIGUOUS_OLD_NAMES = 'optionAmbiguousOldNames';
78+
79+
public const ERROR_AMBIGUOUS_TYPES = 'optionAmbiguousTypes';
80+
5681
/**
5782
* XML path to page size parameter
5883
*/
@@ -229,31 +254,6 @@ class Option extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
229254
*/
230255
protected $_optionCollection;
231256

232-
/**
233-
* Error codes
234-
*/
235-
const ERROR_INVALID_STORE = 'optionInvalidStore';
236-
237-
const ERROR_INVALID_TYPE = 'optionInvalidType';
238-
239-
const ERROR_EMPTY_TITLE = 'optionEmptyTitle';
240-
241-
const ERROR_INVALID_PRICE = 'optionInvalidPrice';
242-
243-
const ERROR_INVALID_MAX_CHARACTERS = 'optionInvalidMaxCharacters';
244-
245-
const ERROR_INVALID_SORT_ORDER = 'optionInvalidSortOrder';
246-
247-
const ERROR_INVALID_ROW_PRICE = 'optionInvalidRowPrice';
248-
249-
const ERROR_INVALID_ROW_SORT = 'optionInvalidRowSort';
250-
251-
const ERROR_AMBIGUOUS_NEW_NAMES = 'optionAmbiguousNewNames';
252-
253-
const ERROR_AMBIGUOUS_OLD_NAMES = 'optionAmbiguousOldNames';
254-
255-
const ERROR_AMBIGUOUS_TYPES = 'optionAmbiguousTypes';
256-
257257
/**
258258
* @var CollectionByPagesIterator
259259
*/

app/code/Magento/Tax/Model/Calculation/Rate.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@ class Rate extends \Magento\Framework\Model\AbstractExtensibleModel implements T
2121
/**
2222
* Constants defined for keys of array, makes typos less likely
2323
*/
24-
const KEY_ID = 'id';
25-
const KEY_COUNTRY_ID = 'tax_country_id';
26-
const KEY_REGION_ID = 'tax_region_id';
27-
const KEY_REGION_NAME = 'region_name';
28-
const KEY_POSTCODE = 'tax_postcode';
29-
const KEY_ZIP_IS_RANGE = 'zip_is_range';
30-
const KEY_ZIP_RANGE_FROM = 'zip_from';
31-
const KEY_ZIP_RANGE_TO = 'zip_to';
32-
const KEY_PERCENTAGE_RATE = 'rate';
33-
const KEY_CODE = 'code';
34-
const KEY_TITLES = 'titles';
24+
public const KEY_ID = 'id';
25+
public const KEY_COUNTRY_ID = 'tax_country_id';
26+
public const KEY_REGION_ID = 'tax_region_id';
27+
public const KEY_REGION_NAME = 'region_name';
28+
public const KEY_POSTCODE = 'tax_postcode';
29+
public const KEY_ZIP_IS_RANGE = 'zip_is_range';
30+
public const KEY_ZIP_RANGE_FROM = 'zip_from';
31+
public const KEY_ZIP_RANGE_TO = 'zip_to';
32+
public const KEY_PERCENTAGE_RATE = 'rate';
33+
public const KEY_CODE = 'code';
34+
public const KEY_TITLES = 'titles';
3535

3636
/**
3737
* @var null

0 commit comments

Comments
 (0)