ENGCOM-1392: [Forwardport] Fix a non well formed numeric value encountered on Magento/Directory/… #14862

magento-engcom-team · magento-engcom-team · commit 21ee3676ead5 · 2018-04-26T03:30:25.000-05:00
- Merge Pull Request #14862 from rostyslav-hymon/magento2:2.3-develop-PR-port-14833 - Merged commits: 1. 09cd446
diff --git a/app/code/Magento/Directory/Model/Currency.php b/app/code/Magento/Directory/Model/Currency.php
@@ -225,7 +225,7 @@ public function convert($price, $toCurrency = null)
         if ($toCurrency === null) {
             return $price;
         } elseif ($rate = $this->getRate($toCurrency)) {
-            return $price * $rate;
+            return floatval($price) * floatval($rate);
         }
 
         throw new \Exception(__(

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ public function convert($price, $toCurrency = null)`
`225`	`225`	`if ($toCurrency === null) {`
`226`	`226`	`return $price;`
`227`	`227`	`} elseif ($rate = $this->getRate($toCurrency)) {`
`228`		`- return $price * $rate;`
	`228`	`+ return floatval($price) * floatval($rate);`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`throw new \Exception(__(`