Skip to content

Commit 18a7e29

Browse files
Merge pull request #2439 from magento-trigger/team3-delivery
[Team 3] Bugfixes
2 parents d3248d0 + 82f3f83 commit 18a7e29

File tree

17 files changed

+197
-28
lines changed

17 files changed

+197
-28
lines changed

app/code/Magento/Cms/Helper/Wysiwyg/Images.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
/**
1111
* Wysiwyg Images Helper.
12-
*
13-
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1412
*/
1513
class Images extends \Magento\Framework\App\Helper\AbstractHelper
1614
{

app/code/Magento/Cms/view/adminhtml/web/js/folder-tree.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ define([
9494

9595
lastExistentFolderEl = folderEl;
9696

97-
if (path.length > 1) {
97+
if (path.length) {
9898
tree.jstree('open_node', folderEl, recursiveOpen);
9999
} else {
100100
tree.jstree('open_node', folderEl, function () {

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Section/AdminProductFormSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@
103103
<element name="AcceptFolderName" type="button" selector=".action-primary.action-accept" />
104104
<element name="StorageRootArrow" type="button" selector="#root > .jstree-icon" />
105105
<element name="checkIfArrowExpand" type="button" selector="//li[@id='root' and contains(@class,'jstree-closed')]" />
106+
<element name="WysiwygArrow" type="button" selector="#d3lzaXd5Zw-- > .jstree-icon" />
107+
<element name="checkIfWysiwygArrowExpand" type="button" selector="//li[@id='d3lzaXd5Zw--' and contains(@class,'jstree-closed')]" />
106108
<element name="confirmDelete" type="button" selector=".action-primary.action-accept" />
107109
</section>
108110
<section name="ProductShortDescriptionWYSIWYGToolbarSection">

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/AdminAddImageToWYSIWYGCatalogCest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
<description value="Admin should be able to add image to WYSIWYG Editor on Catalog Page"/>
2222
<severity value="CRITICAL"/>
2323
<testCaseId value="MAGETWO-84373"/>
24-
<!--Skip because of issue MAGETWO-88266-->
25-
<group value="skip"/>
2624
</annotations>
2725
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToNewCatalog"/>
2826
<waitForPageLoad stepKey="wait1"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/AdminAddImageToWYSIWYGProductCest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
<description value="Admin should be able to add image to WYSIWYG Editor on Product Page"/>
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-84375"/>
19-
<!--Skip because of issue MAGETWO-88266-->
20-
<group value="skip"/>
2119
</annotations>
2220
<before>
2321
<actionGroup ref="LoginActionGroup" stepKey="login"/>
@@ -47,7 +45,8 @@
4745
<fillField selector="{{ProductDescriptionWYSIWYGToolbarSection.FolderName}}" userInput="{{ImageFolder.name}}" stepKey="fillFolderName1" />
4846
<click selector="{{ProductDescriptionWYSIWYGToolbarSection.AcceptFolderName}}" stepKey="acceptFolderName11" />
4947
<waitForLoadingMaskToDisappear stepKey="waitForLoading3" />
50-
<conditionalClick selector="{{ProductDescriptionWYSIWYGToolbarSection.StorageRootArrow}}" dependentSelector="{{ProductDescriptionWYSIWYGToolbarSection.checkIfArrowExpand}}" stepKey="clickArrowIfCloses1" visible="true"/>
48+
<conditionalClick selector="{{ProductDescriptionWYSIWYGToolbarSection.StorageRootArrow}}" dependentSelector="{{ProductDescriptionWYSIWYGToolbarSection.checkIfArrowExpand}}" stepKey="clickStorageRootArrowIfClosed" visible="true"/>
49+
<conditionalClick selector="{{ProductDescriptionWYSIWYGToolbarSection.WysiwygArrow}}" dependentSelector="{{ProductDescriptionWYSIWYGToolbarSection.checkIfWysiwygArrowExpand}}" stepKey="clickWysiwygArrowIfClosed" visible="true"/>
5150
<waitForText userInput="{{ImageFolder.name}}" stepKey="waitForNewFolder1" />
5251
<click userInput="{{ImageFolder.name}}" stepKey="clickOnCreatedFolder1" />
5352
<waitForLoadingMaskToDisappear stepKey="waitForLoading4" />

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Data/CmsPageData.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@
1414
<data key="content">Sample page content. Yada yada yada.</data>
1515
<data key="identifier" unique="suffix">test-page-</data>
1616
</entity>
17+
<entity name="_newDefaultCmsPage" type="cms_page">
18+
<data key="title" unique="suffix">Test CMS Page</data>
19+
<data key="content_heading">Test Content Heading</data>
20+
<data key="content">Sample page content. Yada yada yada.</data>
21+
<data key="identifier" unique="suffix">test-page-</data>
22+
</entity>
1723
<entity name="_duplicatedCMSPage" type="cms_page">
1824
<data key="title">testpage</data>
1925
<data key="content_heading">Test Content Heading</data>
@@ -33,6 +39,7 @@
3339
<data key="shareable">Yes</data>
3440
<data key="value">magento.jpg</data>
3541
<data key="fileName">magento</data>
42+
<data key="extension">jpg</data>
3643
<data key="content">Image content. Yeah.</data>
3744
<data key="height">1000</data>
3845
</entity>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Test/AdminAddImageToWYSIWYGBlockCest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
<description value="Admin should be able to add image to WYSIWYG content of Block"/>
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-84376"/>
19-
<!--Skip because of issue MAGETWO-88266-->
20-
<group value="skip"/>
2119
</annotations>
2220
<before>
2321
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Test/AdminAddImageToWYSIWYGCMSPageCest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
<description value="Admin should be able to add image to WYSIWYG content of CMS Page"/>
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-85825"/>
19-
<!--Skip because of issue MAGETWO-88266-->
20-
<group value="skip"/>
2119
</annotations>
2220
<before>
2321
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />
@@ -47,7 +45,6 @@
4745
<actionGroup ref="saveImage" stepKey="insertImage"/>
4846
<actionGroup ref="fillOutUploadImagePopup" stepKey="fillOutUploadImagePopup" />
4947
<click selector="{{CmsNewPagePageSeoSection.header}}" stepKey="clickExpandSearchEngineOptimisation"/>
50-
<fillField selector="{{CmsNewPagePageSeoSection.urlKey}}" userInput="{{_defaultCmsPage.identifier}}" stepKey="fillFieldUrlKey"/>
5148
<click selector="{{CmsNewPagePageActionsSection.expandSplitButton}}" stepKey="expandButtonMenu"/>
5249
<waitForElementVisible selector="{{CmsNewPagePageActionsSection.splitButtonMenu}}" stepKey="waitForSplitButtonMenuVisible"/>
5350
<click selector="{{CmsNewPagePageActionsSection.savePage}}" stepKey="clickSavePage"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Test/AdminAddVariableToWYSIWYGBlockCest.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
<features value="MAGETWO-36659-[CMS] WYSIWYG update"/>
1313
<stories value="MAGETWO-42158-Variable with WYSIWYG"/>
1414
<group value="Cms"/>
15-
<group value="skip"/>
16-
<!-- Skipped; see MAGETWO-88218 -->
1715
<title value="Admin should be able to add variable to WYSIWYG content of Block"/>
1816
<description value="You should be able to add variable to WYSIWYG content Block"/>
1917
<testCaseId value="MAGETWO-84378"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Newsletter/Test/AdminAddImageToWYSIWYGNewsletterCest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
<description value="Admin should be able to add image to WYSIWYG content Newsletter"/>
1717
<severity value="CRITICAL"/>
1818
<testCaseId value="MAGETWO-84377"/>
19-
<!--Skip because of issue MAGETWO-88266-->
20-
<group value="skip"/>
2119
</annotations>
2220
<before>
2321
<actionGroup ref="LoginActionGroup" stepKey="login"/>
@@ -58,7 +56,6 @@
5856
<waitForPageLoad stepKey="waitForPageLoad9"/>
5957
<seeElement selector="{{StorefrontNewsletterSection.mediaDescription}}" stepKey="assertMediaDescription"/>
6058
<seeElementInDOM selector="{{StorefrontNewsletterSection.ImageSource(ImageUpload3.fileName,ImageUpload3.extension)}}" stepKey="assertMediaSource"/>
61-
<closeTab stepKey="closeTab"/>
6259
<after>
6360
<closeTab stepKey="closeTab"/>
6461
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>

0 commit comments

Comments
 (0)