AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit 092e23bcc305 · 2025-02-01T21:50:35.000+05:30
To fix rounding error in PHP 8.4
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -152,10 +152,10 @@ protected function getStore($scope = null)
     public function round($price)
     {
         // To fix rounding error in PHP 8.4
-        if (version_compare(PHP_VERSION, '8.4', '>=')) {
-            return round((float)sprintf("%.3f", $price), 2);
-        }
-        return round((float) $price, 2);
+        return round(
+            floatval((string) $price),
+            2
+        );
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -152,10 +152,10 @@ protected function getStore($scope = null)`
`152`	`152`	`public function round($price)`
`153`	`153`	`{`
`154`	`154`	`// To fix rounding error in PHP 8.4`
`155`		`- if (version_compare(PHP_VERSION, '8.4', '>=')) {`
`156`		`- return round((float)sprintf("%.3f", $price), 2);`
`157`		`- }`
`158`		`- return round((float) $price, 2);`
	`155`	`+ return round(`
	`156`	`+ floatval((string) $price),`
	`157`	`+ 2`
	`158`	`+ );`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`/**`