Skip to content

Commit ff4747d

Browse files
committed
MC-4965: Text Wrapping Inside Inline WYSIWYG Editors Will Break On Words (Storefront as well for Slide & Banner)
- add new test for text content word wrap
1 parent e518fdb commit ff4747d

File tree

2 files changed

+47
-0
lines changed

2 files changed

+47
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
<element name="emptyTextInImportantStyle" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//div[contains(normalize-space(@class), 'cms-content-important')]" parameterized="true"/>
2929
<element name="imageSource" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//img[contains(@src,'{{var1}}')]" parameterized="true"/>
3030
<element name="inlineWYSIWYGEditorWithTag" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//div[contains(@class,'inline-wysiwyg')]//{{arg2}}" parameterized="true"/>
31+
<element name="wysiwyg" type="text" selector="(//div[@data-role='text'])[{{arg1}}][contains(@class,'inline-wysiwyg')]" parameterized="true"/>
32+
<element name="contentJS" type="text" selector="document.querySelectorAll('div[data-role=text].inline-wysiwyg')[{{arg1}} - 1]" parameterized="true"/>
3133
<!-- Advanced Configuration -->
3234
<element name="alignment" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div[contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
3335
<element name="noAlignment" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div[not(contains(@style,'text-align:'))]" parameterized="true"/>
@@ -79,6 +81,7 @@
7981
<element name="image" type="text" selector="//div[@data-role='text'][{{arg1}}]//img[contains(@src,'{{arg2}}')]" parameterized="true"/>
8082
<element name="textInImportantStyle" type="text" selector="//div[contains(normalize-space(@class), 'cms-content-important') and text()='{{arg1}}']" parameterized="true"/>
8183
<element name="emptyTextInImportantStyle" type="text" selector="//div[@data-role='text'][{{arg1}}]//div[@class='cms-content-important'][not(*)]" parameterized="true"/>
84+
<element name="contentJS" type="text" selector="document.querySelectorAll('[data-role=text][data-element=main]')[{{arg1}} - 1]" parameterized="true"/>
8285
<!-- Advanced Configuration -->
8386
<element name="alignment" type="text" selector="(//div[@data-role='text'])[{{arg1}}][contains(@style,'text-align: {{arg2}};')]" parameterized="true"/>
8487
<element name="noAlignment" type="text" selector="(//div[@data-role='text'])[{{arg1}}][not(contains(@style,'text-align:'))]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2393,6 +2393,50 @@
23932393
<actualResult type="variable">columnOneTextHeight</actualResult>
23942394
</assertGreaterThan>
23952395
</test>
2396+
<test name="TextContentCanWordWrap" extends="BannerPosterContentCanWordWrap">
2397+
<annotations>
2398+
<features value="PageBuilder"/>
2399+
<stories value="Text"/>
2400+
<title value="Text content can wrap words to multiple lines"/>
2401+
<description value="A user can see text content word wrap to multiple lines"/>
2402+
<severity value="CRITICAL"/>
2403+
<useCaseId value="MC-4965"/>
2404+
<testCaseId value="MC-5634"/>
2405+
<group value="pagebuilder"/>
2406+
<group value="pagebuilder-text"/>
2407+
</annotations>
2408+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
2409+
<argument name="contentType" value="PageBuilderTextContentType"/>
2410+
</actionGroup>
2411+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupElements">
2412+
<argument name="group" value="PageBuilderTextContentType"/>
2413+
</actionGroup>
2414+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragIntoStage">
2415+
<argument name="contentType" value="PageBuilderTextContentType"/>
2416+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
2417+
</actionGroup>
2418+
<fillField selector="{{TextOnStage.wysiwyg('1')}}" userInput="{{PageBuilderMessageProperty_WordBreak.value}}" after="dragIntoStage" stepKey="fillTextToTextarea"/>
2419+
<comment userInput="keyForRemoval" stepKey="inlineEdit"/>
2420+
<comment userInput="keyForRemoval" stepKey="openEditMenuOnStage"/>
2421+
<comment userInput="keyForRemoval" stepKey="enterAppearanceProperty"/>
2422+
<comment userInput="keyForRemoval" stepKey="saveEditPanelSettings"/>
2423+
<dragAndDrop selector1="{{ColumnOnBackend.columnX('1')}} {{ColumnOnBackend.columnResizeHandle}}" selector2="{{ColumnOnBackend.columnResizeGridLine('2')}}" x="$guideWidth" stepKey="resizeColumn"/>
2424+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapStage">
2425+
<argument name="page" value="TextOnStage"/>
2426+
<argument name="height" value="80"/>
2427+
</actionGroup>
2428+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapAfterSave">
2429+
<argument name="page" value="TextOnStage"/>
2430+
<argument name="height" value="110"/>
2431+
</actionGroup>
2432+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
2433+
<argument name="contentType" value="PageBuilderTextContentType"/>
2434+
</actionGroup>
2435+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapStorefront">
2436+
<argument name="page" value="TextOnStorefront"/>
2437+
<argument name="height" value="80"/>
2438+
</actionGroup>
2439+
</test>
23962440
<test name="TextInlineWYSIWYGWidgetAndVariableStyle">
23972441
<annotations>
23982442
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)