Skip to content

Commit e518fdb

Browse files
anthoulaanthoula
committed
MC-4965: Text Wrapping Inside Inline WYSIWYG Editors Will Break On Words (Storefront as well for Slide & Banner)
- add new test for slide poster content word wrap - add new test for slide collage left content word wrap
1 parent 1e2993c commit e518fdb

File tree

3 files changed

+98
-0
lines changed

3 files changed

+98
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
<element name="backgroundRepeat" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='wrapper'][contains(@style,'background-repeat: {{arg2}};')]" parameterized="true"/>
8888
<element name="backgroundAttachment" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='wrapper'][contains(@style,'background-attachment: {{arg2}};')]" parameterized="true"/>
8989
<!-- Content Configuration -->
90+
<element name="contentJS" type="text" selector="document.querySelectorAll('[data-role=slide] [data-element=content]')[{{arg1}} - 1]" parameterized="true"/>
9091
<element name="messageContent" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='content']//p[.='{{arg2}}']" parameterized="true"/>
9192
<element name="noMessageContent" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='wrapper']//div[@data-element='content'][not(*)]" parameterized="true"/>
9293
<element name="messageContentTextArea" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='wrapper']//div[@data-element='content'][.='{{arg2}}']" parameterized="true"/>
@@ -134,6 +135,7 @@
134135
<element name="variablePlaceholder" type="text" selector="(//div[contains(@class,'pagebuilder-slide')])[{{arg}}]//*[contains(@class, 'magento-variable magento-placeholder')]" parameterized="true"/>
135136
<element name="widgetPlaceholder" type="text" selector="(//div[contains(@class,'pagebuilder-slide')])[{{arg}}]//*[contains(@class, 'magento-placeholder magento-widget')]" parameterized="true"/>
136137
<element name="tinymce" type="text" selector="(//div[contains(@class,'pagebuilder-slide')])[{{arg}}]//div[contains(@class, 'inline-wysiwyg')]" parameterized="true"/>
138+
<element name="contentJS" type="text" selector="document.querySelectorAll('[data-role=slider] div.inline-wysiwyg')[{{arg1}} - 1]" parameterized="true"/>
137139
<!-- Appearance Configuration -->
138140
<element name="appearance" type="text" selector="(//div[@data-role='slide'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
139141
<element name="slideName" type="button" selector="(//div[@data-role='slide'])[{{arg1}}][@data-slide-name='{{arg2}}']" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,56 @@
118118
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
119119
</actionGroup>
120120
</test>
121+
<test name="SlideCollageLeftContentCanWordWrap" extends="BannerPosterContentCanWordWrap">
122+
<annotations>
123+
<features value="PageBuilder"/>
124+
<stories value="Slider"/>
125+
<title value="Collage Left - Slide content can wrap words to multiple lines"/>
126+
<description value="A user can see slide collage left content word wrap to multiple lines"/>
127+
<severity value="MAJOR"/>
128+
<useCaseId value="MC-4965"/>
129+
<testCaseId value="MC-5635"/>
130+
<group value="pagebuilder"/>
131+
<group value="pagebuilder-slide"/>
132+
<group value="pagebuilder-slideItemCollageLeft"/>
133+
</annotations>
134+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
135+
<argument name="contentType" value="PageBuilderSliderContentType"/>
136+
</actionGroup>
137+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupElements">
138+
<argument name="group" value="PageBuilderSliderContentType"/>
139+
</actionGroup>
140+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragIntoStage">
141+
<argument name="contentType" value="PageBuilderSliderContentType"/>
142+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
143+
</actionGroup>
144+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
145+
<argument name="contentType" value="PageBuilderSliderContentType"/>
146+
<argument name="content" value="{{PageBuilderMessageProperty_WordBreak.value}}"/>
147+
</actionGroup>
148+
<dragAndDrop selector1="{{ColumnOnBackend.columnX('1')}} {{ColumnOnBackend.columnResizeHandle}}" selector2="{{ColumnOnBackend.columnResizeGridLine('6')}}" x="$guideWidth" stepKey="resizeColumn"/>
149+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage">
150+
<argument name="section" value="SlideOnBackend"/>
151+
</actionGroup>
152+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
153+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
154+
</actionGroup>
155+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapStage">
156+
<argument name="page" value="SlideOnBackend"/>
157+
<argument name="height" value="110"/>
158+
</actionGroup>
159+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapAfterSave">
160+
<argument name="page" value="SlideOnBackend"/>
161+
<argument name="height" value="80"/>
162+
</actionGroup>
163+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
164+
<argument name="contentType" value="PageBuilderSliderContentType"/>
165+
</actionGroup>
166+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapStorefront">
167+
<argument name="page" value="SlideOnFrontend"/>
168+
<argument name="height" value="50"/>
169+
</actionGroup>
170+
</test>
121171
<test name="SlideCollageLeftMobileWithMobileImageValues" extends="SlideCollageCenteredMobileWithMobileImageValues">
122172
<annotations>
123173
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,52 @@
235235
</actionGroup>
236236
<seeElement selector="{{SlideOnFrontend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeMessageContentStorefront"/>
237237
</test>
238+
<test name="SlideItemPosterContentCanWordWrap" extends="BannerPosterContentCanWordWrap">
239+
<annotations>
240+
<features value="PageBuilder"/>
241+
<stories value="Slider"/>
242+
<title value="Poster - Slide content can wrap words to multiple lines"/>
243+
<description value="A user can see slide poster content word wrap to multiple lines"/>
244+
<severity value="CRITICAL"/>
245+
<useCaseId value="MC-4965"/>
246+
<testCaseId value="MC-5633"/>
247+
<group value="pagebuilder"/>
248+
<group value="pagebuilder-slide"/>
249+
<group value="pagebuilder-slideItemPoster"/>
250+
</annotations>
251+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
252+
<argument name="contentType" value="PageBuilderSliderContentType"/>
253+
</actionGroup>
254+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupElements">
255+
<argument name="group" value="PageBuilderSliderContentType"/>
256+
</actionGroup>
257+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragIntoStage">
258+
<argument name="contentType" value="PageBuilderSliderContentType"/>
259+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
260+
</actionGroup>
261+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
262+
<argument name="contentType" value="PageBuilderSliderContentType"/>
263+
<argument name="content" value="{{PageBuilderMessageProperty_WordBreak.value}}"/>
264+
</actionGroup>
265+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage">
266+
<argument name="section" value="SlideOnBackend"/>
267+
</actionGroup>
268+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapStage">
269+
<argument name="page" value="SlideOnBackend"/>
270+
<argument name="height" value="110"/>
271+
</actionGroup>
272+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapAfterSave">
273+
<argument name="page" value="SlideOnBackend"/>
274+
<argument name="height" value="80"/>
275+
</actionGroup>
276+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
277+
<argument name="contentType" value="PageBuilderSliderContentType"/>
278+
</actionGroup>
279+
<actionGroup ref="validateContentWordWrap" stepKey="validateContentWordWrapStorefront">
280+
<argument name="page" value="SlideOnFrontend"/>
281+
<argument name="height" value="50"/>
282+
</actionGroup>
283+
</test>
238284
<test name="SlideItemPosterButtonNeverShow">
239285
<annotations>
240286
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)