Skip to content

Commit ff0bcb0

Browse files
dhaeckerdhaecker
committed
MC-3354: All Attributes Banner
- Adding Banner tests for updating all attributes and updating advanced attributes - Updating Banner test for advanced attribute defaults - Updating/Adding supporting data & action groups - Updating Banner selectors - Updating affected tests - Deleting unused slider elements
1 parent 5813187 commit ff0bcb0

13 files changed

+2751
-1795
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,24 @@
6363
<waitForElementVisible selector="{{section.backgroundRepeat(index, backgroundRepeat.styleValue)}}" stepKey="waitForBackgroundRepeat"/>
6464
<waitForElementVisible selector="{{section.backgroundAttachment(index, backgroundAttachment.value)}}" stepKey="waitForBackgroundAttachment"/>
6565
</actionGroup>
66+
<actionGroup name="validateMobileBackgroundAttributes">
67+
<arguments>
68+
<argument name="section"/>
69+
<argument name="mobileBackgroundColor"/>
70+
<argument name="mobileBackgroundPosition" defaultValue="PageBuilderBackgroundPosition_Default"/>
71+
<argument name="mobileBackgroundSize" defaultValue="PageBuilderBackgroundSize_Default"/>
72+
<argument name="mobileBackgroundRepeat" defaultValue="PageBuilderBackgroundRepeat_Default"/>
73+
<argument name="mobileBackgroundAttachment" defaultValue="PageBuilderBackgroundAttachment_Default"/>
74+
<argument name="index" defaultValue="1" type="string"/>
75+
</arguments>
76+
<comment userInput="validateMobileBackgroundAttributes" stepKey="comment"/>
77+
<waitForElementVisible selector="{{section.base(index)}}" stepKey="waitForBaseElement"/>
78+
<waitForElementVisible selector="{{section.mobileBackgroundColor(index, mobileBackgroundColor.rgb)}}" stepKey="waitForBackgroundColor"/>
79+
<waitForElementVisible selector="{{section.mobileBackgroundPosition(index, mobileBackgroundPosition.styleValue)}}" stepKey="waitForBackgroundPosition"/>
80+
<waitForElementVisible selector="{{section.mobileBackgroundSize(index, mobileBackgroundSize.value)}}" stepKey="waitForBackgroundSize"/>
81+
<waitForElementVisible selector="{{section.mobileBackgroundRepeat(index, mobileBackgroundRepeat.styleValue)}}" stepKey="waitForBackgroundRepeat"/>
82+
<waitForElementVisible selector="{{section.mobileBackgroundAttachment(index, mobileBackgroundAttachment.value)}}" stepKey="waitForBackgroundAttachment"/>
83+
</actionGroup>
6684
<actionGroup name="validateBackgroundImage">
6785
<arguments>
6886
<argument name="section"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/AdvancedData.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@
128128
<data key="name">Border Color</data>
129129
<data key="section">advanced</data>
130130
<data key="fieldName">border_color</data>
131+
<data key="value"/>
131132
<data key="placeholderText">No Color</data>
132133
</entity>
133134
<entity name="PageBuilderAdvancedBorderColorProperty_Empty" type="pagebuilder_advanced_border_color_property">
@@ -264,6 +265,7 @@
264265
<data key="name">CSS Classes</data>
265266
<data key="section">advanced</data>
266267
<data key="fieldName">css_classes</data>
268+
<data key="value"/>
267269
</entity>
268270
<entity name="PageBuilderAdvancedCssClassesProperty_Empty" type="pagebuilder_advanced_css_classes_property">
269271
<data key="name">CSS Classes</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 94 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@
1515
<data key="fieldName">appearance</data>
1616
<data key="value">poster</data>
1717
</entity>
18+
<entity name="PageBuilderBannerAppearance_Poster" type="pagebuilder_banner_appearance_property">
19+
<data key="name">Appearance</data>
20+
<data key="section">appearance_fieldset</data>
21+
<data key="fieldName">appearance</data>
22+
<data key="value">poster</data>
23+
</entity>
1824
<entity name="PageBuilderBannerCollageLeftProperty" type="pagebuilder_banner_appearance_property">
1925
<data key="name">Appearance</data>
2026
<data key="section">appearance_fieldset</data>
@@ -109,13 +115,19 @@
109115
<data key="value">hover</data>
110116
</entity>
111117
<!-- Button Text -->
112-
<entity name="PageBuilderBannerButtonTextProperty" type="pagebuilder_banner_buttonText_property">
118+
<entity name="PageBuilderBannerButtonText_Default" type="pagebuilder_banner_button_text_property">
119+
<data key="name">Button Text</data>
120+
<data key="section">contents</data>
121+
<data key="fieldName">button_text</data>
122+
<data key="value"/>
123+
</entity>
124+
<entity name="PageBuilderBannerButtonTextProperty" type="pagebuilder_banner_button_text_property">
113125
<data key="name">Button Text</data>
114126
<data key="section">contents</data>
115127
<data key="fieldName">button_text</data>
116128
<data key="value">Good Morning!</data>
117129
</entity>
118-
<entity name="PageBuilderBannerButtonTextProperty2" type="pagebuilder_banner_buttonText_property2">
130+
<entity name="PageBuilderBannerButtonTextProperty2" type="pagebuilder_banner_button_text_property">
119131
<data key="name">Button Text</data>
120132
<data key="section">contents</data>
121133
<data key="fieldName">button_text</data>
@@ -126,7 +138,7 @@
126138
<data key="name">Button Type</data>
127139
<data key="section">contents</data>
128140
<data key="fieldName">button_type</data>
129-
<data key="value">Primary</data>
141+
<data key="value">pagebuilder-button-primary</data>
130142
<data key="class">true</data>
131143
</entity>
132144
<entity name="PageBuilderBannerButtonTypePrimaryProperty" type="pagebuilder_banner_buttonType_property">
@@ -173,18 +185,26 @@
173185
<data key="value">never</data>
174186
</entity>
175187
<!-- Overlay Color -->
176-
<entity name="PageBuilderBannerContentOverlayColorProperty" type="pagebuilder_banner_contentOverlayColor_property">
188+
<entity name="PageBuilderBannerContentOverlayColorProperty" type="pagebuilder_banner_overlay_color_property">
177189
<data key="name">Overlay Color</data>
178190
<data key="section">contents</data>
179191
<data key="fieldName">overlay_color</data>
180192
<data key="value">#ffffff</data>
181193
</entity>
194+
<entity name="PageBuilderBannerOverlayColor_FF0000" type="pagebuilder_banner_overlay_color_property">
195+
<data key="name">Overlay Color</data>
196+
<data key="section">contents</data>
197+
<data key="fieldName">overlay_color</data>
198+
<data key="value">#ff0000</data>
199+
<data key="rgb">255,0,0</data>
200+
</entity>
182201
<!-- Overlay Transparency -->
183202
<entity name="PageBuilderBannerOverlayTransparencyProperty" type="pagebuilder_banner_overlayTransparency_property">
184203
<data key="name">Overlay Transparency</data>
185204
<data key="section">contents</data>
186205
<data key="fieldName">overlay_transparency</data>
187206
<data key="value">70</data>
207+
<data key="decimal">0.7</data>
188208
</entity>
189209
<entity name="PageBuilderBannerOverlayTransparencyDefaultProperty" type="pagebuilder_banner_overlayTransparencyDefault_property">
190210
<data key="name">Overlay Transparency</data>
@@ -197,17 +217,87 @@
197217
<data key="section">contents</data>
198218
<data key="fieldName">overlay_transparency</data>
199219
<data key="value">-1</data>
220+
<data key="errorMessage">Please enter a value greater than or equal to 0.</data>
200221
</entity>
201222
<entity name="PageBuilderBannerOverlayTransparencyInvalidMaxProperty" type="pagebuilder_banner_overlayTransparency_property">
202223
<data key="name">Overlay Transparency</data>
203224
<data key="section">contents</data>
204225
<data key="fieldName">overlay_transparency</data>
205226
<data key="value">101</data>
227+
<data key="errorMessage">Please enter a value less than or equal to 100.</data>
206228
</entity>
207229
<entity name="PageBuilderBannerOverlayTransparencyInvalidTypeProperty" type="pagebuilder_banner_overlayTransparency_property">
208230
<data key="name">Overlay Transparency</data>
209231
<data key="section">contents</data>
210232
<data key="fieldName">overlay_transparency</data>
211233
<data key="value">abc</data>
234+
<data key="errorMessage">Please enter a valid number in this field.</data>
235+
</entity>
236+
<!-- Padding -->
237+
<entity name="PageBuilderBannerCollageLeftPaddingPropertyDefault" type="pagebuilder_banner_collage_left_padding_property">
238+
<data key="name">Margins and Padding</data>
239+
<data key="section">advanced</data>
240+
<data key="fieldName">margins_and_padding</data>
241+
<data key="paddingTop">40</data>
242+
<data key="paddingRight">40</data>
243+
<data key="paddingBottom">40</data>
244+
<data key="paddingLeft">40</data>
245+
<data key="desktopValue">40px calc(50% + 40px) 40px 40px</data>
246+
<data key="mobileValue">40px 40px 40px 40px</data>
247+
</entity>
248+
<entity name="PageBuilderBannerCollageLeftPaddingPropertyUnique" type="pagebuilder_banner_collage_left_padding_property">
249+
<data key="name">Margins and Padding</data>
250+
<data key="section">advanced</data>
251+
<data key="fieldName">margins_and_padding</data>
252+
<data key="paddingTop">1</data>
253+
<data key="paddingRight">2</data>
254+
<data key="paddingBottom">3</data>
255+
<data key="paddingLeft">4</data>
256+
<data key="desktopValue">1px calc(50% + 2px) 3px 4px</data>
257+
<data key="mobileValue">1px 2px 3px 4px</data>
258+
</entity>
259+
<entity name="PageBuilderBannerCollageCenterPaddingPropertyDefault" type="pagebuilder_banner_collage_center_padding_property">
260+
<data key="name">Margins and Padding</data>
261+
<data key="section">advanced</data>
262+
<data key="fieldName">margins_and_padding</data>
263+
<data key="paddingTop">1</data>
264+
<data key="paddingRight">2</data>
265+
<data key="paddingBottom">3</data>
266+
<data key="paddingLeft">4</data>
267+
<data key="desktopValue">40px calc(25% + 40px)</data>
268+
<data key="mobileValue">40px 40px 40px 40px</data>
269+
</entity>
270+
<entity name="PageBuilderBannerCollageCenterPaddingPropertyUnique" type="pagebuilder_banner_collage_center_padding_property">
271+
<data key="name">Margins and Padding</data>
272+
<data key="section">advanced</data>
273+
<data key="fieldName">margins_and_padding</data>
274+
<data key="paddingTop">1</data>
275+
<data key="paddingRight">2</data>
276+
<data key="paddingBottom">3</data>
277+
<data key="paddingLeft">4</data>
278+
<data key="desktopValue">1px calc(25% + 2px) 3px calc(25% + 4px)</data>
279+
<data key="mobileValue">1px 2px 3px 4px</data>
280+
</entity>
281+
<entity name="PageBuilderBannerCollageRightPaddingPropertyDefault" type="pagebuilder_banner_collage_right_padding_property">
282+
<data key="name">Margins and Padding</data>
283+
<data key="section">advanced</data>
284+
<data key="fieldName">margins_and_padding</data>
285+
<data key="paddingTop">1</data>
286+
<data key="paddingRight">2</data>
287+
<data key="paddingBottom">3</data>
288+
<data key="paddingLeft">4</data>
289+
<data key="desktopValue">40px 40px 40px calc(50% + 40px)</data>
290+
<data key="mobileValue">40px 40px 40px 40px</data>
291+
</entity>
292+
<entity name="PageBuilderBannerCollageRightPaddingPropertyUnique" type="pagebuilder_banner_collage_right_padding_property">
293+
<data key="name">Margins and Padding</data>
294+
<data key="section">advanced</data>
295+
<data key="fieldName">margins_and_padding</data>
296+
<data key="paddingTop">1</data>
297+
<data key="paddingRight">2</data>
298+
<data key="paddingBottom">3</data>
299+
<data key="paddingLeft">4</data>
300+
<data key="desktopValue">1px 2px 3px calc(50% + 4px)</data>
301+
<data key="mobileValue">1px 2px 3px 4px</data>
212302
</entity>
213303
</entities>

0 commit comments

Comments
 (0)