Skip to content

Commit 5813187

Browse files
dhaeckerdhaecker
committed
MC-3352: Delete Banner
- Updating Delete Banner & Delete Map tests
1 parent 5546831 commit 5813187

File tree

2 files changed

+48
-13
lines changed

2 files changed

+48
-13
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -393,15 +393,15 @@
393393
<click selector="{{BannerOnFrontend.linkUrl(PageBuilderBannerLinkUrlProperty.value)}}" stepKey="clickLinkUrl"/>
394394
<amOnPage url="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="amOnLinkPage"/>
395395
</test>
396-
<test name="BannerRemoveBannerFromStage">
396+
<test name="BannerDelete">
397397
<annotations>
398398
<features value="PageBuilder"/>
399399
<stories value="Banner"/>
400-
<title value="Remove banner content type from stage"/>
401-
<description value="A user should be able to remove banner content type from a row."/>
400+
<title value="Delete Banner"/>
401+
<description value="A user should be able to delete a banner content type. Verify on Stage and Storefront."/>
402402
<severity value="CRITICAL"/>
403-
<useCaseId value="MAGETWO-83928"/>
404-
<testCaseId value="MAGETWO-84919"/>
403+
<useCaseId value="MC-3239"/>
404+
<testCaseId value="MC-3367"/>
405405
<group value="pagebuilder"/>
406406
<group value="pagebuilder-banner"/>
407407
<group value="pagebuilder-bannerCommon"/>
@@ -414,16 +414,40 @@
414414
<after>
415415
<actionGroup ref="logout" stepKey="logout"/>
416416
</after>
417+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
418+
<argument name="contentType" value="PageBuilderBannerContentType"/>
419+
</actionGroup>
420+
<!-- Add Banner and Save Page -->
421+
<comment userInput="Add Banner and Save Page" stepKey="commentAddBanner"/>
417422
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
418423
<argument name="group" value="PageBuilderBannerContentType"/>
419424
</actionGroup>
420425
<actionGroup ref="dragContentTypeToStage" stepKey="dragContentTypeToStage">
421426
<argument name="contentType" value="PageBuilderBannerContentType"/>
422427
</actionGroup>
423-
<actionGroup ref="removeEmptyContentTypeFromStage" stepKey="removeBanner">
428+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
429+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
430+
<!-- Delete Banner -->
431+
<comment userInput="Delete Banner" stepKey="commentDeleteBanner"/>
432+
<actionGroup ref="removeContentTypeFromStage" stepKey="removeBanner">
433+
<argument name="contentType" value="PageBuilderBannerContentType"/>
434+
</actionGroup>
435+
<!-- Validate Stage -->
436+
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
437+
<dontSeeElementInDOM selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderBannerContentType.role, '1')}}" stepKey="dontSeeContentTypeInStage"/>
438+
<!-- Save Page -->
439+
<comment userInput="Save Page" stepKey="commentSavePage"/>
440+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
441+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
442+
<!-- Validate Stage After Save -->
443+
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
444+
<dontSeeElementInDOM selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderBannerContentType.role, '1')}}" stepKey="dontSeeContentTypeInStage2"/>
445+
<!-- Validate Storefront -->
446+
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
447+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
424448
<argument name="contentType" value="PageBuilderBannerContentType"/>
425449
</actionGroup>
426-
<dontSeeElement selector="{{PageBuilderStage.contentTypeInStage(PageBuilderBannerContentType.role)}}" stepKey="dontSeeContentTypeInStage"/>
450+
<dontSeeElementInDOM selector="{{BannerOnFrontend.base('1')}}" stepKey="dontSeeContentTypeInStorefront"/>
427451
</test>
428452
<test name="BannerHasNoRequired">
429453
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapCommonComponentTest.xml

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1643,7 +1643,7 @@
16431643
<features value="PageBuilder"/>
16441644
<stories value="Map"/>
16451645
<title value="Delete Map"/>
1646-
<description value="A user should be able to delete a map content type. Verify on Stage amd Storefront."/>
1646+
<description value="A user should be able to delete a map content type. Verify on Stage and Storefront."/>
16471647
<severity value="CRITICAL"/>
16481648
<useCaseId value="MAGETWO-87083"/>
16491649
<testCaseId value="MAGETWO-88897"/>
@@ -1662,6 +1662,8 @@
16621662
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
16631663
<argument name="contentType" value="PageBuilderMapContentType"/>
16641664
</actionGroup>
1665+
<!-- Add Map and Save Page -->
1666+
<comment userInput="Add Map and Save Page" stepKey="commentAddMap"/>
16651667
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupInteractive">
16661668
<argument name="group" value="PageBuilderMapContentType"/>
16671669
</actionGroup>
@@ -1670,18 +1672,27 @@
16701672
</actionGroup>
16711673
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanel"/>
16721674
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1673-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
1675+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1676+
<!-- Delete Map -->
1677+
<comment userInput="Delete Map" stepKey="commentDeleteMap"/>
16741678
<actionGroup ref="removeContentTypeFromStage" stepKey="removeContentTypeFromStage">
16751679
<argument name="contentType" value="PageBuilderMapContentType"/>
16761680
</actionGroup>
1677-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
1678-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
1679-
<!-- Verify Map Not In Stage -->
1681+
<!-- Validate Stage -->
1682+
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
16801683
<dontSeeElementInDOM selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderMapContentType.role, '1')}}" stepKey="dontSeeContentTypeInStage"/>
1684+
<!-- Save Page -->
1685+
<comment userInput="Save Page" stepKey="commentSavePage"/>
1686+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
1687+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
1688+
<!-- Validate Stage After Save -->
1689+
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
1690+
<dontSeeElementInDOM selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderMapContentType.role, '1')}}" stepKey="dontSeeContentTypeInStage2"/>
1691+
<!-- Validate Storefront -->
1692+
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
16811693
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
16821694
<argument name="contentType" value="PageBuilderMapContentType"/>
16831695
</actionGroup>
1684-
<!-- Verify Map Not In Storefront -->
16851696
<dontSeeElementInDOM selector="{{MapOnStorefront.base('1')}}" stepKey="dontSeeContentTypeInStorefront"/>
16861697
</test>
16871698
<test name="MapCannotAddToStage">

0 commit comments

Comments
 (0)