Skip to content

Commit fa77098

Browse files
committed
PB-366: Templates Lower Level Test Coverage
- Fix static tests
1 parent b79d68f commit fa77098

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

app/code/Magento/PageBuilder/Model/TemplateRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88

99
namespace Magento\PageBuilder\Model;
1010

11-
use Magento\Framework\Filesystem;
1211
use Magento\Framework\Api\SearchCriteria\CollectionProcessorInterface;
1312
use Magento\Framework\Api\SearchCriteriaInterface;
1413
use Magento\Framework\Exception\CouldNotDeleteException;
1514
use Magento\Framework\Exception\CouldNotSaveException;
1615
use Magento\Framework\Exception\NoSuchEntityException;
16+
use Magento\Framework\Filesystem;
1717
use Magento\PageBuilder\Api\Data\TemplateInterface;
1818
use Magento\PageBuilder\Api\Data\TemplateSearchResultsInterfaceFactory;
1919
use Magento\PageBuilder\Api\TemplateRepositoryInterface;

app/code/Magento/PageBuilder/Ui/Component/Template/DataProvider.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,10 @@ public function __construct(
6565
}
6666

6767
/**
68-
* @inheritdoc
68+
* Add a filter into the data provider
69+
*
70+
* @param Filter $filter
71+
* @return mixed|void
6972
*/
7073
public function addFilter(Filter $filter)
7174
{

app/code/Magento/PageBuilder/composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"magento/module-theme": "*",
2121
"magento/module-wishlist": "*",
2222
"magento/module-require-js": "*",
23+
"magento/media-storage": "*",
2324
"php": "~7.1.3||~7.2.0||~7.3.0"
2425
},
2526
"suggest": {

app/code/Magento/PageBuilder/etc/module.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<module name="Magento_Theme"/>
1818
<module name="Magento_Search"/>
1919
<module name="Magento_CatalogWidget"/>
20+
<module name="Magento_MediaStorage"/>
2021
</sequence>
2122
</module>
2223
</config>

app/code/Magento/PageBuilder/view/adminhtml/web/js/modal/confirm-alert.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@
88
*/
99
define([
1010
'jquery',
11-
'underscore',
1211
'jquery-ui-modules/widget',
13-
'Magento_Ui/js/modal/alert',
14-
'mage/translate'
15-
], function ($, _) {
12+
'Magento_Ui/js/modal/alert'
13+
], function ($) {
1614
'use strict';
1715

1816
$.widget('mage.confirmAlert', $.mage.alert, {

dev/tests/integration/testsuite/Magento/PageBuilder/Controller/Adminhtml/Template/SaveTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ public function testSaveAction()
121121
'name' => 'Automated Template',
122122
'template' => '<div data-content-type="row"></div>',
123123
'createdFor' => 'any',
124+
// phpcs:disable Magento2.Files.LineLength.MaxExceeded
124125
'previewImage' => 'data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/2wBDAQMDAwQDBAgEBAgQCwkLEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBD/wAARCAAZABkDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAn/xAAUEAEAAAAAAAAAAAAAAAAAAAAA/8QAFAEBAAAAAAAAAAAAAAAAAAAAAP/EABQRAQAAAAAAAAAAAAAAAAAAAAD/2gAMAwEAAhEDEQA/AJVAAAAAAAA//9k='
125126
];
126127
$this->getRequest()->setPostValue($post)->setMethod(HttpRequest::METHOD_POST);

0 commit comments

Comments
 (0)